Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt integration-tests fixes from 4.4-release #4815

Merged

Conversation

rhrazdil
Copy link

@rhrazdil rhrazdil commented Mar 25, 2020

  • bring into master fixes done during 4.4 regression testing
  • removed changes tiny to large test case as we only support changing flavor to custom now
  • Moved Unpause tests under vm.actions.scenario.ts

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2020
@rhrazdil rhrazdil changed the title [WIP] kubevirt integration-tests fixes from [WIP] kubevirt integration-tests fixes from 4.4-release Mar 25, 2020
@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Mar 25, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@rhrazdil rhrazdil changed the title [WIP] kubevirt integration-tests fixes from 4.4-release kubevirt integration-tests fixes from 4.4-release Mar 30, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2020
@rhrazdil
Copy link
Author

/test e2e-gcp-console

@yaacov
Copy link
Member

yaacov commented Mar 30, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrazdil, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2020
removeLeakableResource(leakedResources, testVM);
removeLeakableResource(leakedResources, testVMI);
removeLeakedResources(leakedResources);
deleteResources([testVM, testVMI]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@openshift-merge-robot openshift-merge-robot merged commit bf8a0e1 into openshift:master Mar 30, 2020
@spadgett spadgett added this to the v4.5 milestone Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants