Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining Table.Row prop typings #4834

Merged
merged 1 commit into from Apr 1, 2020
Merged

Fix remaining Table.Row prop typings #4834

merged 1 commit into from Apr 1, 2020

Conversation

vojtechszocs
Copy link
Contributor

This is a follow-up to #4783.

Fixed remaining occurences and narrowed Table.Row prop type to RowFunction only.

cc @benjaminapetersen @spadgett @christianvogt @rawagner

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Mar 26, 2020
@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2020
vojtechszocs
vojtechszocs commented Mar 26, 2020
View reviewed changes
frontend/public/components/factory/table.tsx
@@ -338,11 +338,11 @@ export type RowFunctionArgs<T = any, C = any> = {
customData?: C;
};

export type RowFunction<T = any, C = any> = (args: RowFunctionArgs<T, C>) => JSX.Element;
export type RowFunction<T = any, C = any> = (args: RowFunctionArgs<T, C>) => React.ReactElement;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christianvogt FYI, returning ReactNode as suggested yields some TS errors, so I've changed it to ReactElement.

@vojtechszocs vojtechszocs force-pushed the TableRow-types-followup branch 2 times, most recently from eb5007f to a7f13a9 Compare April 1, 2020 16:35
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Apr 1, 2020
@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020
@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 79a8b93 into openshift:master Apr 1, 2020
@spadgett spadgett added this to the v4.5 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/olm Related to OLM lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vojtechszocs @christianvogt @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot