Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1821846: Hide OpenShift Cluster Manager when branding is azure #4837

Conversation

nilsanderselde
Copy link
Contributor

Fixes Azure/ARO-RP#298.

Needs to be backported to release-4.3.

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Mar 26, 2020
@nilsanderselde nilsanderselde force-pushed the hide-oc-manager-for-aro branch 2 times, most recently from 4d8b2f6 to f65ee6f Compare March 26, 2020 22:26
@openshift-ci-robot openshift-ci-robot added the component/dashboard Related to dashboard label Mar 26, 2020
@jim-minter
Copy link

@spadgett bump, please could you take a look at this? Please could you help us get this backported to release-4.3? Please advise @nilsanderselde what he needs to do.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilsanderselde, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@spadgett spadgett changed the title Hide OpenShift Cluster Manager when branding is azure Bug 1821846: Hide OpenShift Cluster Manager when branding is azure Apr 7, 2020
@openshift-ci-robot
Copy link
Contributor

@nilsanderselde: This pull request references Bugzilla bug 1821846, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1821846: Hide OpenShift Cluster Manager when branding is azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 7, 2020
@spadgett spadgett added this to the v4.5 milestone Apr 7, 2020
@spadgett
Copy link
Member

spadgett commented Apr 7, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

spadgett commented Apr 7, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit db0f11f into openshift:master Apr 7, 2020
@openshift-ci-robot
Copy link
Contributor

@nilsanderselde: All pull requests linked via external trackers have merged: openshift/console#4837. Bugzilla bug 1821846 has been moved to the MODIFIED state.

In response to this:

Bug 1821846: Hide OpenShift Cluster Manager when branding is azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@spadgett: new pull request created: #4956

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@spadgett: new pull request created: #4957

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nilsanderselde nilsanderselde deleted the hide-oc-manager-for-aro branch April 12, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dashboard Related to dashboard lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link to cloud.redhat.com in the web console
6 participants