feat add support to move sink for eventSource #4847

invincibleJai · 2020-03-30T11:07:26Z

Fixes:
https://issues.redhat.com/browse/ODC-2550

Analysis / Root cause:
User can't change/move Sink for event source through web console

Solution Description:
User can change/move Sink for event source through web console through context menu/action item

Screen shots / Gifs for design review:

cc @serenamarie125

Unit test coverage report:

Browser conformance:

Chrome
Firefox
Safari
Edge

serenamarie125

Looks great @invincibleJai ! LGTM

andrewballantyne · 2020-03-31T16:51:04Z

/kind feature

frontend/packages/knative-plugin/src/components/sink-source/SinkSourceController.tsx

frontend/packages/knative-plugin/src/components/sink-source/__tests__/SinkSourceModal.spec.tsx

sahil143 · 2020-04-01T21:53:03Z

frontend/packages/knative-plugin/src/components/sink-source/__tests__/SinkSourceModal.spec.tsx

+      },
+    },
+  };
+  const formProps: SinkSourceModalProps = {


make this common so the other modal component unit test can use this? WDYT?

i was wondering if we could reuse this formik properities in all other formik wrapped components but not sure if we can keep it as separate utility for reusing.

@sahil143 @karthikjeeyar we can reuse for modal component , any suggested file/location to place it as it could be in different packages as well

have moved it to shared 24331a6

frontend/packages/knative-plugin/src/components/sink-source/__tests__/SinkSourceModal.spec.tsx

sahil143 · 2020-04-01T21:55:42Z

frontend/packages/knative-plugin/src/components/sink-source/SinkSourceModal.tsx

+      <ModalBody>
+        <p>
+          Select a sink to move the event source
+          <strong>{` ${resourceName} `}</strong>


Suggested change

{` ${resourceName} `}

{resourceName}

@sahil143 used { ${resourceName} } to add space i.e

this would also work 😉

 {resourceName} 

Doesn't this work?
Select a sink to move the event source {resourceName} to

let me try it

It's working , not sure what i was thinking 🤔

frontend/packages/knative-plugin/src/components/sink-source/__tests__/SinkSource.spec.tsx

karthikjeeyar · 2020-04-02T05:32:18Z

frontend/packages/knative-plugin/src/components/sink-source/__tests__/SinkSourceModal.spec.tsx

+      },
+    },
+  };
+  const formProps: SinkSourceModalProps = {


i was wondering if we could reuse this formik properities in all other formik wrapped components but not sure if we can keep it as separate utility for reusing.

frontend/packages/knative-plugin/src/components/sink-source/SinkSource.tsx

sahil143

/lgtm

verified changes locally

sahil143

/lgtm

christianvogt · 2020-04-02T17:06:52Z

frontend/packages/knative-plugin/src/components/sink-source/SinkSourceModal.tsx

+      <ModalBody>
+        <p>
+          Select a sink to move the event source
+          <strong>{` ${resourceName} `}</strong>


Doesn't this work?
Select a sink to move the event source {resourceName} to

christianvogt · 2020-04-02T17:13:37Z

frontend/packages/knative-plugin/src/components/sink-source/SinkSourceController.tsx

+import SinkSource from './SinkSource';
+
+type SinkSourceControllerProps = {
+  obj: K8sResourceKind;


Can we be more specific on the prop name. Why not source? I see this pattern is copied from TrafficSplittingController ;/

christianvogt · 2020-04-02T17:16:09Z

@invincibleJai I also made this comment but it seems to be buried in the thread somewhere:
https://github.com/openshift/console/pull/4847/files#r402471794

… no chnage in sink

christianvogt · 2020-04-02T18:46:27Z

/lgtm
/approve

openshift-ci-robot · 2020-04-02T18:47:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, invincibleJai, sahil143, serenamarie125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the component/knative Related to knative-plugin label Mar 30, 2020

openshift-ci-robot requested review from TheRealJon and vikram-raj March 30, 2020 11:07

openshift-ci-robot added the component/shared Related to console-shared label Mar 30, 2020

invincibleJai changed the title ~~fead add support tp mpve sink for eventSource~~ feat add support tp move sink for eventSource Mar 30, 2020

invincibleJai changed the title ~~feat add support tp move sink for eventSource~~ feat add support to move sink for eventSource Mar 30, 2020

invincibleJai changed the title ~~feat add support to move sink for eventSource~~ [WIP] feat add support to move sink for eventSource Mar 30, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2020

feat: adds support tp move sink for eventSource

f37ecef

invincibleJai force-pushed the feat-eventsrc-sink-modal branch from 21c3117 to f37ecef Compare March 31, 2020 10:05

invincibleJai changed the title ~~[WIP] feat add support to move sink for eventSource~~ feat add support to move sink for eventSource Mar 31, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2020

serenamarie125 approved these changes Mar 31, 2020

View reviewed changes

invincibleJai force-pushed the feat-eventsrc-sink-modal branch from 0bc1cb2 to d4f377c Compare March 31, 2020 12:38

openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 31, 2020

karthikjeeyar reviewed Mar 31, 2020

View reviewed changes

frontend/packages/knative-plugin/src/components/sink-source/SinkSourceController.tsx Outdated Show resolved Hide resolved

karthikjeeyar reviewed Mar 31, 2020

View reviewed changes

frontend/packages/knative-plugin/src/components/sink-source/__tests__/SinkSourceModal.spec.tsx Outdated Show resolved Hide resolved

frontend/packages/knative-plugin/src/components/sink-source/__tests__/SinkSourceModal.spec.tsx Outdated Show resolved Hide resolved

invincibleJai force-pushed the feat-eventsrc-sink-modal branch from d4f377c to dcf25c8 Compare April 1, 2020 10:29

sahil143 reviewed Apr 1, 2020

View reviewed changes

karthikjeeyar reviewed Apr 2, 2020

View reviewed changes

adds spec for sinkSource, sinkSourceModal

f5c943f

invincibleJai force-pushed the feat-eventsrc-sink-modal branch 2 times, most recently from a9528c4 to 24331a6 Compare April 2, 2020 08:43

sahil143 reviewed Apr 2, 2020

View reviewed changes

frontend/packages/knative-plugin/src/components/sink-source/SinkSource.tsx Outdated Show resolved Hide resolved

invincibleJai force-pushed the feat-eventsrc-sink-modal branch from 24331a6 to e5fa3cd Compare April 2, 2020 10:09

sahil143 reviewed Apr 2, 2020

View reviewed changes

openshift-ci-robot assigned sahil143 Apr 2, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020

invincibleJai force-pushed the feat-eventsrc-sink-modal branch from e5fa3cd to d418c69 Compare April 2, 2020 11:06

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020

sahil143 approved these changes Apr 2, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020

christianvogt reviewed Apr 2, 2020

View reviewed changes

moves formik props to shared utils and added check to disable save if…

bd50cc7

… no chnage in sink

invincibleJai force-pushed the feat-eventsrc-sink-modal branch from d418c69 to bd50cc7 Compare April 2, 2020 18:34

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020

openshift-ci-robot assigned christianvogt Apr 2, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020

openshift-merge-robot merged commit b0c09f3 into openshift:master Apr 2, 2020

spadgett added this to the v4.5 milestone Apr 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat add support to move sink for eventSource #4847

feat add support to move sink for eventSource #4847

invincibleJai commented Mar 30, 2020 •

edited

serenamarie125 left a comment

andrewballantyne commented Mar 31, 2020

sahil143 Apr 1, 2020

karthikjeeyar Apr 2, 2020

invincibleJai Apr 2, 2020

invincibleJai Apr 2, 2020

sahil143 Apr 1, 2020

invincibleJai Apr 2, 2020

sahil143 Apr 2, 2020

christianvogt Apr 2, 2020

invincibleJai Apr 2, 2020

invincibleJai Apr 2, 2020

karthikjeeyar Apr 2, 2020

sahil143 left a comment •

edited

sahil143 left a comment

christianvogt Apr 2, 2020

christianvogt Apr 2, 2020

invincibleJai Apr 2, 2020

christianvogt commented Apr 2, 2020

christianvogt commented Apr 2, 2020

openshift-ci-robot commented Apr 2, 2020

	<strong>{` ${resourceName} `}</strong>
	<strong>{resourceName}</strong>

feat add support to move sink for eventSource #4847

feat add support to move sink for eventSource #4847

Conversation

invincibleJai commented Mar 30, 2020 • edited

serenamarie125 left a comment

Choose a reason for hiding this comment

andrewballantyne commented Mar 31, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sahil143 left a comment • edited

Choose a reason for hiding this comment

sahil143 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christianvogt commented Apr 2, 2020

christianvogt commented Apr 2, 2020

openshift-ci-robot commented Apr 2, 2020

invincibleJai commented Mar 30, 2020 •

edited

sahil143 left a comment •

edited