Kubevirt - Fix node qualifier qualifying undefined labels #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atiratree
reviewed
Mar 31, 2020
| if ( | ||
| nodeLabels && | ||
| filteredLabels.every(({ key, value }) => | ||
| value ? nodeLabels[key] === value : !!nodeLabels[key], |
There was a problem hiding this comment.
can the node label exist but be empty as well? Would _.has() make more sense here?
glekner
force-pushed
the
node-qualifier-fix1
branch
from
b0a0b0f
to
c6f9d11
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glekner, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a Toleration's label value is undefined, and if the label is missing from the node we get
undefined === undefinedwhich is true, causing a missing label to look like a node has it.this fixes it.