Detect and handle webpack module cycles #4874
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to get a handle on the situation around circular module dependencies.
When running
yarn check-cycles
, module cycles are detected viaCircularDependencyPlugin
and subsequently handled atemit
phase via ad-hocHandleCyclesPlugin
.Cycle report is written to
frontend/.webpack-cycles
file.Example cycle report:
Cycle report analysis:
A -> B -> A
cyclescc @spadgett @christianvogt