Fix infinite network calls and handle network errors gracefully #4875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
component/dev-console
frontend/packages/dev-console/src/components/helm/HelmInstallUpgradePage.tsx
Outdated
Show resolved
Hide resolved
rohitkrai03
force-pushed
the
helm-install-bug-fix
branch
from
a25e936
to
18e0894
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/ODC-3475
Analysis / Root cause: Due to incorrect use of
useEffectdependency array, infinite calls to network were happening on install and upgrade forms of helm. Also, if the network call fails the page kept loading infinitely without handling it gracefully.Solution Description: Fix the
useEffectdependency by creating a context and using it everywhere. Use TS optional chaining to safeguard against network failures.Browser conformance: