Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubevirt - Affinity modal #4884

Merged
merged 2 commits into from Apr 7, 2020

Conversation

glekner
Copy link
Contributor

@glekner glekner commented Apr 1, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. component/core Related to console core functionality labels Apr 1, 2020
@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Apr 1, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2020
@glekner glekner force-pushed the affinity-modal branch 17 times, most recently from 7d115a1 to dc5918b Compare April 5, 2020 02:55
@glekner glekner changed the title WIP: Kubevirt - Affinity modal Kubevirt - Affinity modal Apr 6, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2020
@glekner
Copy link
Contributor Author

glekner commented Apr 6, 2020

Ok guys, this turned out to be big.

Lets get this in before freeze ;)
can you review @suomiy @yaacov?

@glekner glekner force-pushed the affinity-modal branch 2 times, most recently from 2ce2d3b to 801b208 Compare April 6, 2020 23:46
@yaacov
Copy link
Member

yaacov commented Apr 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@yaacov
Copy link
Member

yaacov commented Apr 7, 2020

/approve

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 7, 2020
@yaacov
Copy link
Member

yaacov commented Apr 7, 2020

/lgtm
great ❗

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@yaacov
Copy link
Member

yaacov commented Apr 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1412c3d into openshift:master Apr 7, 2020
@spadgett spadgett added this to the v4.5 milestone May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants