Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring: Add Creator column to silences lists #4886

Merged
merged 1 commit into from Apr 7, 2020
Merged

Monitoring: Add Creator column to silences lists #4886

merged 1 commit into from Apr 7, 2020

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Apr 2, 2020 •
edited

Adds a "Creator" column to the main silences list and to the silences
list on the alert details page.

Also refactors so that the two lists now share the same code.

screenshot

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020
@kyoto kyoto force-pushed the monitoring-add-creator-to-silences-list branch from 5add798 to fa380f5 Compare April 2, 2020 07:11
@kyoto
Monitoring: Add Creator column to silences lists
3224527 
Adds a "Creator" column to the main silences list and to the silences
list on the alert details page.

Also refactors so that the two lists now share the same code.
@kyoto kyoto force-pushed the monitoring-add-creator-to-silences-list branch from fa380f5 to 3224527 Compare April 2, 2020 07:48
spadgett
spadgett approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@kyoto: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 3224527 link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 848d693 into openshift:master Apr 7, 2020
@kyoto kyoto deleted the monitoring-add-creator-to-silences-list branch April 7, 2020 22:57
@spadgett spadgett added this to the v4.5 milestone May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kyoto @openshift-ci-robot @spadgett @dtaylor113 @openshift-merge-robot