Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no dockerfile pipeline template #4932

Conversation

andrewballantyne
Copy link
Contributor

@andrewballantyne andrewballantyne commented Apr 6, 2020

Fixes:
https://issues.redhat.com/browse/ODC-3502

Analysis / Root cause:
Caused by #4857, and we didn't catch it because the template was already there (by the Operator at install). The cluster Christian was testing on just had no templates (for whatever reason) and thus revealed this issue.

Solution Description:
Just optional chain the property... it's not even used for this path.

Screen shots / Gifs for design review:
(no change)
image

Test setup:

  • OpenShift Pipeline Operator installed
  • No dockerfile strategy Pipeline (buildah) in the openshift namespace
  • Navigate to "From Dockerfile"

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Apr 6, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020
@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 74f208b into openshift:master Apr 6, 2020
@spadgett spadgett added this to the v4.5 milestone Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants