Bug 1821407: Clarify alert for supported operator's install mode #4948

jhadvig · 2020-04-07T15:59:47Z

openshift-ci-robot · 2020-04-07T15:59:53Z

@jhadvig: This pull request references Bugzilla bug 1821407, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1821407: Remove 'openshift-operators' namespace from single names…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-07T16:01:14Z

@jhadvig: This pull request references Bugzilla bug 1821407, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1821407: Remove 'openshift-operators' namespace from single namespace install mode dropdown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jhadvig · 2020-04-07T16:01:39Z

/cherrypick release-4.4

openshift-cherrypick-robot · 2020-04-07T16:01:40Z

@jhadvig: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-07T16:02:03Z

@jhadvig: This pull request references Bugzilla bug 1821407, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1821407: Remove 'openshift-operators' namespace from single namespace install mode dropdown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2020-04-07T16:06:09Z

/hold

...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx

jhadvig · 2020-04-08T08:26:04Z

@spadgett updated the alert's wording:

...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx

jhadvig · 2020-04-09T10:07:40Z

@spadgett comment addressed. Thanks !

spadgett · 2020-04-09T13:28:31Z

...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx

+          {`The operator group in the '${selectedTargetNamespace}' namespace does not support the
+          ${
+            selectedInstallMode === InstallModeType.InstallModeTypeAllNamespaces
+              ? 'global'
+              : 'single namespace'
+          }
+          installation mode.`}


No reason for this to be a string, it can be markup.

Suggested change

{`The operator group in the '${selectedTargetNamespace}' namespace does not support the

${

selectedInstallMode === InstallModeType.InstallModeTypeAllNamespaces

? 'global'

: 'single namespace'

}

installation mode.`}

The operator group in the {selectedTargetNamespace} namespace does not support the

{

selectedInstallMode === InstallModeType.InstallModeTypeAllNamespaces

? 'global'

: 'single namespace'

}

installation mode.

jhadvig · 2020-04-09T13:51:30Z

@spadgett comment addressed

spadgett

/approve
/lgtm

spadgett · 2020-04-09T15:24:58Z

/retest

spadgett · 2020-04-09T15:25:12Z

/hold cancel

benjaminapetersen

/approve
/lgtm

openshift-ci-robot · 2020-04-09T16:21:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/operator-lifecycle-manager/OWNERS~~ [benjaminapetersen,jhadvig,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-04-09T17:40:56Z

@jhadvig: All pull requests linked via external trackers have merged: openshift/console#4948. Bugzilla bug 1821407 has been moved to the MODIFIED state.

In response to this:

Bug 1821407: Clarify alert for supported operator's install mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-04-09T17:41:22Z

@jhadvig: new pull request created: #4997

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 7, 2020

jhadvig changed the title ~~Bug 1821407: Remove 'openshift-operators' namespace from single names…~~ Bug 1821407: Remove 'openshift-operators' namespace from single namespace install mode dropdown Apr 7, 2020

jhadvig assigned benjaminapetersen Apr 7, 2020

openshift-ci-robot requested review from jeff-phillips-18 and spadgett April 7, 2020 16:02

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2020

spadgett reviewed Apr 7, 2020

View reviewed changes

...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx Outdated Show resolved Hide resolved

jhadvig force-pushed the bz1821407 branch from 48fd36b to 1462177 Compare April 8, 2020 08:23

jhadvig changed the title ~~Bug 1821407: Remove 'openshift-operators' namespace from single namespace install mode dropdown~~ Bug 1821407: Clarify alert for supported operator's install mode Apr 8, 2020

spadgett reviewed Apr 8, 2020

View reviewed changes

...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx Outdated Show resolved Hide resolved

jhadvig force-pushed the bz1821407 branch from 1462177 to c7784f2 Compare April 9, 2020 10:07

spadgett reviewed Apr 9, 2020

View reviewed changes

Bug 1821407: Clarify alert for supported operator's install mode

167dba4

jhadvig force-pushed the bz1821407 branch from c7784f2 to 167dba4 Compare April 9, 2020 13:51

spadgett approved these changes Apr 9, 2020

View reviewed changes

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2020

openshift-ci-robot assigned spadgett Apr 9, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2020

benjaminapetersen approved these changes Apr 9, 2020

View reviewed changes

openshift-merge-robot merged commit 9ed85ae into openshift:master Apr 9, 2020

openshift-cherrypick-robot mentioned this pull request Apr 9, 2020

[release-4.4] Bug 1821410: Clarify alert for supported operator's install mode #4997

Merged

spadgett added this to the v4.5 milestone Apr 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1821407: Clarify alert for supported operator's install mode #4948

Bug 1821407: Clarify alert for supported operator's install mode #4948

jhadvig commented Apr 7, 2020 •

edited

openshift-ci-robot commented Apr 7, 2020

openshift-ci-robot commented Apr 7, 2020

jhadvig commented Apr 7, 2020

openshift-cherrypick-robot commented Apr 7, 2020

openshift-ci-robot commented Apr 7, 2020

spadgett commented Apr 7, 2020

jhadvig commented Apr 8, 2020

jhadvig commented Apr 9, 2020

spadgett Apr 9, 2020

jhadvig commented Apr 9, 2020

spadgett left a comment

spadgett commented Apr 9, 2020

spadgett commented Apr 9, 2020

benjaminapetersen left a comment

openshift-ci-robot commented Apr 9, 2020

openshift-ci-robot commented Apr 9, 2020

openshift-cherrypick-robot commented Apr 9, 2020

Bug 1821407: Clarify alert for supported operator's install mode #4948

Bug 1821407: Clarify alert for supported operator's install mode #4948

Conversation

jhadvig commented Apr 7, 2020 • edited

openshift-ci-robot commented Apr 7, 2020

openshift-ci-robot commented Apr 7, 2020

jhadvig commented Apr 7, 2020

openshift-cherrypick-robot commented Apr 7, 2020

openshift-ci-robot commented Apr 7, 2020

spadgett commented Apr 7, 2020

jhadvig commented Apr 8, 2020

jhadvig commented Apr 9, 2020

spadgett Apr 9, 2020

Choose a reason for hiding this comment

jhadvig commented Apr 9, 2020

spadgett left a comment

Choose a reason for hiding this comment

spadgett commented Apr 9, 2020

spadgett commented Apr 9, 2020

benjaminapetersen left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Apr 9, 2020

openshift-ci-robot commented Apr 9, 2020

openshift-cherrypick-robot commented Apr 9, 2020

jhadvig commented Apr 7, 2020 •

edited