Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1822647: Change Azure logo to the new, generic Red Hat OpenShift logo #4954

Merged
merged 1 commit into from Apr 9, 2020

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Apr 7, 2020

From Libby Levi in brand:

Got an answer on logos for the OpenShift / Azure product. Since it's not a Red Hat offering, it doesn't have its own Red Hat product logo. Instead, you can use the regular "Red Hat OpenShift" logo as needed.

After:
Screen Shot 2020-04-07 at 4 58 33 PM
Screen Shot 2020-04-07 at 5 00 19 PM

cc: @luciddreamz, @jim-minter

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Apr 7, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@jim-minter
Copy link

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2020
@jim-minter
Copy link

Please don't merge this for now, am running this by some people.

@jim-minter
Copy link

/hold cancel

sigh.

@rhamilto it'd be preferable to backport this to 4.4 and 4.3 otherwise it'll take a very long time to take effect.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2020
@rhamilto
Copy link
Member Author

rhamilto commented Apr 8, 2020

@rhamilto it'd be preferable to backport this to 4.4 and 4.3 otherwise it'll take a very long time to take effect.

we can certainly do that, but note the change to the new logos with the fedora is specific to 4.5, so it seems like we'd want to keep that consistent across product variants?

@jim-minter
Copy link

If we did the backport promptly, we could probably GA with the new logo and not have a change down the line, which may have its value given that the text is changing.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto rhamilto changed the title Change Azure logo to the new, generic Red Hat OpenShift logo Bug 1822647: Change Azure logo to the new, generic Red Hat OpenShift logo Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Bugzilla bug 1822647, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1822647: Change Azure logo to the new, generic Red Hat OpenShift logo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 9, 2020
@rhamilto rhamilto changed the title Bug 1822647: Change Azure logo to the new, generic Red Hat OpenShift logo Change Azure logo to the new, generic Red Hat OpenShift logo Apr 9, 2020
@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

@rhamilto: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Change Azure logo to the new, generic Red Hat OpenShift logo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto changed the title Change Azure logo to the new, generic Red Hat OpenShift logo Bug 1822647: Change Azure logo to the new, generic Red Hat OpenShift logo Apr 9, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Bugzilla bug 1822647, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1822647: Change Azure logo to the new, generic Red Hat OpenShift logo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit eac5d52 into openshift:master Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

@rhamilto: All pull requests linked via external trackers have merged: openshift/console#4954. Bugzilla bug 1822647 has been moved to the MODIFIED state.

In response to this:

Bug 1822647: Change Azure logo to the new, generic Red Hat OpenShift logo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto deleted the azure-logo branch April 9, 2020 19:21
@spadgett spadgett added this to the v4.5 milestone Apr 14, 2020
@m1kola m1kola mentioned this pull request Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants