New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1822647: Change Azure logo to the new, generic Red Hat OpenShift logo #4954
Conversation
/hold |
Please don't merge this for now, am running this by some people. |
/hold cancel sigh. @rhamilto it'd be preferable to backport this to 4.4 and 4.3 otherwise it'll take a very long time to take effect. |
we can certainly do that, but note the change to the new logos with the fedora is specific to 4.5, so it seems like we'd want to keep that consistent across product variants? |
If we did the backport promptly, we could probably GA with the new logo and not have a change down the line, which may have its value given that the text is changing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rhamilto: This pull request references Bugzilla bug 1822647, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhamilto: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhamilto: This pull request references Bugzilla bug 1822647, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhamilto: All pull requests linked via external trackers have merged: openshift/console#4954. Bugzilla bug 1822647 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
From Libby Levi in brand:
After:
cc: @luciddreamz, @jim-minter