New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove row class so page has proper margins at mobile. #4958
Conversation
frontend/public/components/error.tsx
Outdated
<div className="row"> | ||
<ExpandCollapse textCollapsed="Show Details" textExpanded="Hide Details"> | ||
<h3 className="co-section-heading-tertiary">{props.title}</h3> | ||
<div className="form-group"> | ||
<label htmlFor="description">Description: </label> | ||
<p>{props.errorMessage}</p> | ||
</div> | ||
<div className="form-group"> | ||
<label htmlFor="componentTrace">Component Trace: </label> | ||
<div className="co-copy-to-clipboard__stacktrace-width-height"> | ||
<CopyToClipboard value={props.componentStack.trim()} /> | ||
<div className="col-xs-12"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need Bootstrap grid at all here? If we simply removed <div className="row">
, is the bug fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That also works. Updated pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @sg00dwin 👍
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, dtaylor113, sg00dwin, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1812663