kubevirt: add sample Role to grant privileges for non-admin to run v2v #4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
So far, the v2v controller deployment is still managed by the UI. This is planed to be changed but recent state is like that. To allow a non-admin user to run "Import VM" (v2v), read access to the `v2v-vmware` configmap in the `openshift-cnv` namespace needs to be granted. This patch conatins sample `Role` and `RoleBinding` objects to do so for a named user. In a nutshell, to grant access for a non-admin user, the admin needs to: - update/add the name of the user in the `role.v2v-vmware.yaml` - `oc apply -f role.v2v-vmware.yaml` To verify, the non-admin user should get successful result for: - `oc get configmap v2v-vmware -n openshift-cnv -o yaml`
openshift-ci-robot
added
component/kubevirt
|
/retest |
|
Permissions for I will further change the example from a |
mareklibra
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
mareklibra
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mareklibra, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the v2v controller deployment is still managed by the UI.
This is planed to be changed but recent state is like that.
To allow a non-admin user to run "Import VM" (v2v), read access
to the
v2v-vmwareconfigmap in theopenshift-cnvnamespaceneeds to be granted.
This patch contains sample
RoleandRoleBindingobjects to do so fora named user.
In a nutshell, to grant access for a non-admin user, the admin needs to:
role.v2v-vmware.yamloc apply -f role.v2v-vmware.yamlTo verify, the non-admin user should get successful result for:
oc get configmap v2v-vmware -n openshift-cnv -o yamlPermissions to access
kubevirt-storage-class-defaultsconfigmap were removed from this PR in favor of kubevirt/hyperconverged-cluster-operator#498 . However, the user needs to have read access to this configmap to be able to start v2v.As a workaround till kubevirt/hyperconverged-cluster-operator#498 lands, corresponding row in the
role.v2v-vmware.yamlcan be uncommented.