Transform public/module/k8s/index.ts into re-export-only module #4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
component/core
vojtechszocs
force-pushed
the
transform-module-k8s-index
branch
from
3fb9e70
to
5804930
Compare
vojtechszocs
commented
Apr 9, 2020
| }; | ||
|
|
||
| // https://github.com/kubernetes/api/blob/release-1.16/core/v1/types.go#L2411-L2432 | ||
| type PodPhase = 'Pending' | 'Running' | 'Succeeded' | 'Failed' | 'Unknown'; |
There was a problem hiding this comment.
Note, this is no longer exported as it would clash with PodPhase from public/module/k8s/pods.ts.
|
/lgtm one step closer to hopefully removing index files |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While convenient, in bigger projects, index files tend to contribute to cyclic module dependencies, appearing as inner elements of such cycles.
Index files containing re-exports like
export * from './foo';shouldn't contain module-specific exports due to export shadowing ⭐ and increased complexity.⭐
export type PodPhaseinpublic/module/k8s/pods.tsis shadowed byexport type PodPhaseinpublic/module/k8s/index.tswhen imported via the index file.