Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Helm release rollback #5007

Merged
merged 3 commits into from Apr 15, 2020
Merged

Add support for Helm release rollback #5007

merged 3 commits into from Apr 15, 2020

Conversation

rohitkrai03
Copy link
Contributor

@rohitkrai03 rohitkrai03 commented Apr 9, 2020 •
edited

Fixes: https://issues.redhat.com/browse/ODC-3060

Analysis / Root cause:
There is no way for a user to rollback a helm release to a specific revision.

Solution Description: Add support for rollback action in list page, details page, topology and history tab of Helm Release.

This PR -

  • Refactors RadioButtonField into RadioGroupField and RadioButtonField to handle use cases such as single radio button without the form group.
  • Adds a new Helm Rollback form that list all the revisions of that helm release in a table and shows a radio button in the first column of the table.
  • Adds the rollback action to helm list page, helm details page and topology.
  • Adds a new action that opens a confirm modal for the rollback on History tab of Helm Release details page.
  • Changes the way helm release secret was sent to the Details page. Earlier it was sending the first secret resource in the array which might be an older version of the release. Updated the logic to find the latest version of the release secret.

Screen shots / Gifs for design review:
Form -
HelmRollbackForm

History Tab -
HelmRollbackHistoryTab

cc: @openshift/team-ux-review @serenamarie125 @parvathyvr

Unit test coverage report:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Apr 9, 2020
@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Apr 9, 2020
@rohitkrai03 rohitkrai03 force-pushed the helm-rollback branch 3 times, most recently from b382799 to e716c45 Compare April 10, 2020 03:33
christianvogt
christianvogt reviewed Apr 14, 2020
View reviewed changes
Copy link
Contributor

@christianvogt christianvogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be called Revision History:
image

frontend/packages/dev-console/src/components/helm/details/history/HelmReleaseHistoryRow.tsx Outdated Show resolved Hide resolved
frontend/packages/dev-console/src/components/helm/HelmReleaseRollbackPage.tsx Outdated Show resolved Hide resolved
@christianvogt
Copy link
Contributor

On first load of the revision history table, the sort order is incorrect:
image

If this is an issue with the underlying table, create a separate issue to track.

@rohitkrai03 rohitkrai03 force-pushed the helm-rollback branch 2 times, most recently from ed95670 to e95b193 Compare April 14, 2020 21:49
@rohitkrai03
Copy link
Contributor Author

On first load of the revision history table, the sort order is incorrect:
image

If this is an issue with the underlying table, create a separate issue to track.

Bug to track the table sorting issue - https://issues.redhat.com/browse/ODC-3563

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@rohitkrai03
Copy link
Contributor Author

/retest

1 similar comment
@rohitkrai03
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9b70973 into openshift:master Apr 15, 2020
@spadgett spadgett added this to the v4.5 milestone Apr 16, 2020
@rohitkrai03 rohitkrai03 deleted the helm-rollback branch July 24, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvogt christianvogt christianvogt left review comments

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rohitkrai03 @christianvogt @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot