Topology: Refactor types and operations #5010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
kind/cleanup
jeff-phillips-18
changed the title
| @@ -179,7 +180,7 @@ export class DndManagerImpl implements DndManager { | |||
|
|
|||
| beginDrag( | |||
| sourceIds: string | string[], | |||
| operation: string, | |||
| operation: DragOperationWithType, | |||
There was a problem hiding this comment.
Suggested change
| operation: DragOperationWithType, | |
| operation: DragOperationWithType | undefined, |
| ): boolean => { | ||
| return !!( | ||
| operation && | ||
| (typeof (operation as any).type === 'string' || Object.keys(operation).length > 0) |
There was a problem hiding this comment.
Can we use a proper type? Or a guard type function.
Suggested change
| (typeof (operation as any).type === 'string' || Object.keys(operation).length > 0) | |
| (typeof (operation as DragOperationWithType).type === 'string' || Object.keys(operation).length > 0) |
| const graphWorkloadDropTargetSpec: DropTargetSpec< | ||
| GraphElement, | ||
| const graphDropTargetSpec: DropTargetSpec< | ||
| GraphElement | DragNodeObject, |
There was a problem hiding this comment.
I wonder if this was incorrectly typed before. Can we not make it:
Suggested change
| GraphElement | DragNodeObject, | |
| DragNodeObject, |
jeff-phillips-18
force-pushed
the
refactor-types-operations
branch
from
1ddf5f8
to
e22f15d
Compare
jeff-phillips-18
force-pushed
the
refactor-types-operations
branch
from
e22f15d
to
77ff234
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-3167
Analysis / Root cause:
The current topology drag/drop feature requires components to understand what is being dragged and what items are allowed based on the operation and item type.
Solution Description:
Update drag types to include information about the object being dragged rather than depending on a specific type of drag object.
Update the drag operation to include information about the operation rather than depending on specific drag operation types.
Screen shots / Gifs for design review:
No visual changes
Browser conformance:
/kind cleanup