Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show last 50 events in Activity card #5028

Merged
merged 1 commit into from Apr 15, 2020
Merged

Show last 50 events in Activity card #5028

merged 1 commit into from Apr 15, 2020

Conversation

rawagner
Copy link
Contributor

@andybraren Im wondering if we want to notify user that we are showing only last 50 ?

@openshift-ci-robot openshift-ci-robot added component/dashboard Related to dashboard component/shared Related to console-shared labels Apr 14, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Apr 14, 2020
@rawagner
Copy link
Contributor Author

rawagner commented Apr 14, 2020 •
edited

Screenshot from 2020-04-14 22-23-22

Added view all events link in case we have more than 50 events

andybraren
andybraren approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@andybraren andybraren left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And just some context for history's sake: showing the most recent 50 events instead of an infinite scroll of all events avoids some react-virtualized infinite scroll bugginess that happens when activities and events appear at once. Adding this "View all events" link to the very bottom of the list intends to make it clear that there are still more events available that aren't included in this card.

Related react-virtualized bug:
bvaughn/react-virtualized#1324

spadgett
spadgett approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@spadgett spadgett added this to the v4.5 milestone Apr 15, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andybraren, rawagner, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 23ee5be into openshift:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@andybraren andybraren andybraren approved these changes

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rawagner @openshift-ci-robot @spadgett @andybraren @openshift-merge-robot