Add container source form in event source add flow

[karthikjeeyar]

Fixes:- https://issues.redhat.com/browse/ODC-3532

Analysis / Root cause:
Container source option is missing in event source creation flow.

Solution Description:
Added container source option in event source creation flow
doc: https://github.com/knative/docs/tree/master/docs/eventing/samples/container-source

screenshot:

Form structure:

Unit test converage:
containerSourceSection:

containersource validations:

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

cc: @serenamarie125 @christianvogt

[karthikjeeyar]

/kind feature
/assign @invincibleJai

[serenamarie125]

@karthikjeeyar this is looking good, thanks for doing this! Approved by UX

We will likely have some copy updates for help text, but UX won't be proposing til all PRs for Feature Freeze are merged.

[karthikjeeyar]

@karthikjeeyar this is looking good, thanks for doing this! Approved by UX

We will likely have some copy updates for help text, but UX won't be proposing til all PRs for Feature Freeze are merged.

Thanks Serena, we will have tech debt item to align with UX updates post FF.

[invincibleJai]

can we have

template: {
    spec: {
      containers: [
        {
          image: '',
          name: '',
          args: [{ name: '' }],
          env: [],
        },
      ]
  }
}

then we can pass it as is to getEventSourcesDepResource and avoid util getContainerSourceResource

[karthikjeeyar]

We cannot avoid the util function as MulticolumnField value return an array objects
ie: args: [ {name: 'x'} ] which is needs transformation in that util function to make it array of strings. eg: `args: ['x'].

[invincibleJai]

Thanks @karthikjeeyar Verified locally , works as expected

/approve

/assign @sahil143

[sahil143]

If there is a case one of the values prop is undefined then please use optional chaining to get env values in a const something like envValues.

[karthikjeeyar]

I use this envPath in setFieldValue function below, so it will not work if i use optional chaining path in Formik and moreover the values has a default env values as initialValues which will be always present.

[karthikjeeyar]

Based on your previous comment, if we are destructuring then we no longer need this Path variable.

[sahil143]

Yes agreed! After destructuring, this is not needed. this was just a suggestion in case some values are optional.

[sahil143]

Suggested change

	const initialEnvValues = !_.isEmpty(values[envPath])
	const initialEnvValues = !_.isEmpty(envValues)

[sahil143]

same as above

[divyanshiGupta]

I think here also it should be yup.object().shape({image: yup.string().required('Required')})

[karthikjeeyar]

You can either use yup.object().shape({x: y}) or directly pass the shape in the object's constructor yup.object({x:y}). Both does exactly the same thing.
Refer: https://github.com/jquense/yup#object
Usually, i do object().shape if there is nested object, for plain one level object i pass the shape inside the object(shape)

[divyanshiGupta]

Okay. Got it. Thanks

[divyanshiGupta]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, invincibleJai, karthikjeeyar, serenamarie125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/knative-plugin/OWNERS [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment