Bug 1824029: Handle undefined MachineConfigPools status

[jhadvig]

When creating a fresh MCP and immediately redirecting to the MCP list page, the created MCP is missing the status field. Defaulting to Unknown for the condition columns when the status is missing.
Screen:

Wasnt really sure here if Unknown is better then -

/assign @spadgett

[openshift-ci-robot]

@jhadvig: This pull request references Bugzilla bug 1824029, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1824029: Handle undefined MachineConfigPools status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/cherry-pick release-4.4

[openshift-cherrypick-robot]

@jhadvig: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

Suggested change

	if (_.isUndefined(mcp.status)) {
	return K8sResourceConditionStatus.Unknown;
	}
	const { conditions } = mcp.status;
	const { conditions } = mcp.status || {};

[jhadvig]

@spadgett comment addressed. PTAL

[spadgett]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [jhadvig,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jhadvig: All pull requests linked via external trackers have merged: openshift/console#5068. Bugzilla bug 1824029 has been moved to the MODIFIED state.

In response to this:

Bug 1824029: Handle undefined MachineConfigPools status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@jhadvig: new pull request created: #5102

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/cherry-pick release-4.3

[openshift-cherrypick-robot]

@jhadvig: #5068 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	frontend/public/components/machine-config-pool.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/machine-config-pool.tsx
CONFLICT (content): Merge conflict in frontend/public/components/machine-config-pool.tsx
Patch failed at 0001 Bug 1824029: Handle undefined MachineConfigPools status

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.