Remove method searchYAML from console-shared #5074
Conversation
openshift-ci-robot
added
component/kubevirt
| @@ -225,8 +225,12 @@ describe('Test clone VM.', () => { | |||
|
|
|||
| it('Cloned VM has vm.kubevirt.io/name label.', () => { | |||
| expect( | |||
| searchYAML(`vm.kubevirt.io/name: ${vm.name}`, clonedVM.name, clonedVM.namespace, 'vm'), | |||
| ).toBeTruthy(); | |||
| _.get( | |||
There was a problem hiding this comment.
Consider _.has or optional chaining here.
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#optional-chaining
| _.get( | ||
| getLabels(getResourceObject(vm.name, vm.namespace, 'vmi')), | ||
| 'vm.kubevirt.io/name', | ||
| undefined, |
There was a problem hiding this comment.
No need to pass the third arg here. If no default is passed, undefined would be returned anyway.
There was a problem hiding this comment.
I wanted to be explicit, but yeah, it's unnecessary. Removed it.
rhrazdil
force-pushed
the
refactor-console-shared
branch
from
638d8e9
to
5cb3ae0
Compare
|
CI keeps failing |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhrazdil, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
As pointed out by @spadgett in #2125,
searchYAML has several pitfalls and should not be used.
Removed this method from console-shared and updated test cases that used this method.