Update PatternFly to major release v4.0 #5081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
component/dashboard
dtaylor113
force-pushed
the
pf-prerelease-v4
branch
from
62a5254
to
3785c58
Compare
openshift-ci-robot
removed
the
needs-rebase
dtaylor113
force-pushed
the
pf-prerelease-v4
branch
2 times, most recently
from
9fdff5e
to
52830ec
Compare
openshift-ci-robot
added
the
needs-rebase
dtaylor113
force-pushed
the
pf-prerelease-v4
branch
from
52830ec
to
4f239de
Compare
openshift-ci-robot
removed
the
needs-rebase
|
@dtaylor113 @jcaianirh We should make sure we test the layout and tooltips on the Monitoring -> Dashboards and Monitoring -> Metrics page when we bump Patternfly charts to the next major release. I noticed some problems when I tried the new Victory version. cc @kyoto Fixed custom tooltips via 5cb4b35 |
openshift-ci-robot
added
the
needs-rebase
dtaylor113
force-pushed
the
pf-prerelease-v4
branch
from
4f239de
to
e9665b2
Compare
openshift-ci-robot
added
component/lso
1 task
dtaylor113
force-pushed
the
pf-prerelease-v4
branch
2 times, most recently
from
7f64ce8
to
d621bbc
Compare
|
Investigating protractor integration test failure for storage suite |
|
/lgtm |
dtaylor113
force-pushed
the
pf-prerelease-v4
branch
from
97c4934
to
69f84a8
Compare
dtaylor113
force-pushed
the
pf-prerelease-v4
branch
from
69f84a8
to
c599351
Compare
comment out, will fix in follow up PR
dtaylor113
force-pushed
the
pf-prerelease-v4
branch
from
c599351
to
f5acad4
Compare
|
Remaining issues, particularly those raised by UXD, will be tracked in: https://issues.redhat.com/browse/CONSOLE-2304 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, rhamilto, sg00dwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spadgett
added
the
kind/dependency-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This WIP PR contains OpenShift console code changes required to update to the PatternFly v4 RC2! Thanks to @redallen, @jschuler, and everyone on the PatternFly team for making the transition as easy as possible.
Please note that this PR touches many, many files across plug-ins and dev console.
More work is needed to address the visual changes introduced
Additional PF v4 Upgrade Resources
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1841858
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1841912