New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update StartNodeMaintenanceModal to use useK8sWatchResource hook #5087
Update StartNodeMaintenanceModal to use useK8sWatchResource hook #5087
Conversation
b7084ed
to
8fcbeea
Compare
/assign @rawagner |
frontend/packages/metal3-plugin/src/components/modals/StartNodeMaintenanceModal.tsx
Outdated
Show resolved
Hide resolved
👍 nice |
279c8b5
to
47b19c1
Compare
Instead of Firehose wrapper. Remove unused create-modal-resource-launcher module.
47b19c1
to
c626718
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jtomasek, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
/hold cancel |
... instead of Firehose wrapper