Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1828966: Don't blacklist SecurityContextConstraints on the search page #5101

Merged

Conversation

spadgett
Copy link
Member

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 17, 2020
@spadgett spadgett force-pushed the remove-scc-search-blacklist branch from 3e45a1b to b29d7ed Compare April 17, 2020 20:41
@spadgett spadgett changed the title Don't blackliist SecurityContextConstraints on the search page Don't blacklist SecurityContextConstraints on the search page Apr 17, 2020
@spadgett
Copy link
Member Author

Screenshot_2020-04-17 Search · OKD

@spadgett spadgett force-pushed the remove-scc-search-blacklist branch from b29d7ed to b2f958c Compare April 17, 2020 21:21
@openshift-ci-robot openshift-ci-robot added the component/olm Related to OLM label Apr 17, 2020
@@ -204,7 +204,7 @@ describe('Interacting with a `OwnNamespace` install mode Operator (Prometheus)',
expect(crudView.successMessage.getText()).toContain('example has been updated to version');
});

it('displays Kubernetes objects associated with the `Prometheus` in its "Resources" section', async () => {
xit('displays Kubernetes objects associated with the `Prometheus` in its "Resources" section', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test needs to be disabled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test needs to be disabled?

@benjaminapetersen I mean to push that to #5100, removed from this PR

@spadgett spadgett force-pushed the remove-scc-search-blacklist branch from b2f958c to c2f4895 Compare April 17, 2020 21:30
@spadgett spadgett removed the component/olm Related to OLM label Apr 22, 2020
@spadgett
Copy link
Member Author

/retest

@benjaminapetersen
Copy link
Contributor

Want to treat this as a bug?

Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett changed the title Don't blacklist SecurityContextConstraints on the search page Bug 1828966: Don't blacklist SecurityContextConstraints on the search page Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1828966, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1828966: Don't blacklist SecurityContextConstraints on the search page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 28, 2020
@spadgett spadgett added this to the v4.5 milestone Apr 28, 2020
@spadgett
Copy link
Member Author

/cherry-pick release-4.4

@openshift-cherrypick-robot

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e3decf5 into openshift:master Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: All pull requests linked via external trackers have merged: openshift/console#5101. Bugzilla bug 1828966 has been moved to the MODIFIED state.

In response to this:

Bug 1828966: Don't blacklist SecurityContextConstraints on the search page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@spadgett: new pull request created: #5221

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the remove-scc-search-blacklist branch May 1, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants