Bug 1824356: Fix Role Binding filter issue #5127
Conversation
|
@bipuladh: This pull request references Bugzilla bug 1824356, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/medium
bugzilla/valid-bug
| @@ -55,10 +55,11 @@ export const tableFilters: TableFilterMap = { | |||
| 'silence-state': (filter, silence) => filter.selected.has(silenceState(silence)), | |||
|
|
|||
| // Filter role by role kind | |||
| 'role-kind': (filter, role) => filter.selected.has(roleType(role)), | |||
| 'role-kind': (filter, role) => filter.selected.has(roleType(role)) || filter.selected.size === 0, | |||
There was a problem hiding this comment.
This is going to be an issue for a bunch of other filters as well. We need to find a way to put the "no filters selected" logic in one place.
There was a problem hiding this comment.
@spadgett I searched the entire file for such issues. Most of them were handled previously only these two were not handled.
There was a problem hiding this comment.
However, I will search the entire console. And update here.
There was a problem hiding this comment.
We have a lot of duplicate logic in this file, though. I worry about future bugs.
I'll let it through since it's not necessarily a new problem.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@bipuladh: All pull requests linked via external trackers have merged: openshift/console#5077, openshift/console#5127. Bugzilla bug 1824356 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @spadgett