Bug 1835597: Add easier way to support selectors for multiple versions in OCS Tests #5137

bipuladh · 2020-04-21T20:08:02Z

Add a way to write tests with support for multiple versions of selectors.
cc @ebondare @shyRozen

bipuladh · 2020-04-21T20:19:27Z

/hold

bipuladh · 2020-04-21T20:39:46Z

/hold

bipuladh · 2020-04-28T13:40:19Z

/unhold

bipuladh · 2020-04-28T13:40:29Z

/hold cancel

bipuladh · 2020-05-05T20:49:23Z

The motive behind this PR:

Declare selectors as objects for different versions.
Use environment variables to detect the OCP Version.
Based on the OCP version return the appropriate object that has the required selectors.

gnehapk · 2020-05-07T08:49:01Z

frontend/packages/ceph-storage-plugin/integration-tests/views/installFlow.view.ts

+
+export const currentSelectors = (() => {
+  switch (VERSION) {
+    case 'OCP_44':


As discussed, can you please rename the version's name to OCP_4.4.

gnehapk · 2020-05-07T08:50:41Z

frontend/packages/ceph-storage-plugin/integration-tests/views/installFlow.view.ts

+
+  getStorageClusterLink: async () => {
+    const index = await getOperatorHubCardIndex('Storage Cluster');
+    const link = $(`article:nth-child(${index + 1}) a`);


Suggested change

const link = $(`article:nth-child(${index + 1}) a`);

return $(`article:nth-child(${index + 1}) a`);

gnehapk · 2020-05-07T08:58:04Z

frontend/packages/ceph-storage-plugin/integration-tests/views/installFlow.view.ts

+          .getText();
+        await click(checkBox);
+        await browser.wait(until.elementToBeSelected(checkBox));
+        selectedNodes.push(nodeName);


Can you explain what are you checking here? Are you individually selecting nodes and not by select all nodes?

On second though selecting all at once would be much easier. Thanks will look into it.

gnehapk · 2020-05-07T09:08:58Z

frontend/packages/ceph-storage-plugin/integration-tests/views/installFlow.view.ts

@@ -130,78 +157,39 @@ export class InstallCluster {
    this.namespace = namespace;


Where have you used this property?

frontend/packages/ceph-storage-plugin/integration-tests/views/installFlow.view.ts

gnehapk · 2020-05-08T03:05:12Z

@bipuladh Since you have removed the ocp-tests folder, the package.json also needs to be modified.

gnehapk · 2020-05-13T08:49:41Z

frontend/packages/ceph-storage-plugin/integration-tests/tests/1-install/installFlow.scenario.ts

+      await sendKeys(filterInput, STORAGE_CLASS_PATTERNS.NOOBAA);
+      const noobaaClass = await getDataFromRowAndCol(0, 1, podNameFilter);
+      expect(noobaaClass.includes(STORAGE_CLASS_PATTERNS.NOOBAA)).toBe(true);
+    });


We should also add check for osd pods.

osd pods cause flakiness.

gnehapk · 2020-05-13T10:41:14Z

/test e2e-gcp-console

gnehapk · 2020-05-14T04:10:24Z

frontend/packages/ceph-storage-plugin/integration-tests/tests/1-install/installFlow.scenario.ts

-    await sendKeys(filterInput, STORAGE_CLASS_PATTERNS.NOOBAA);
-    const noobaaClass = await getDataFromRowAndCol(0, 1, podNameFilter);
-    expect(noobaaClass.includes(STORAGE_CLASS_PATTERNS.NOOBAA)).toBe(true);
+    it('tests if 3 rook-ceph-osd-prepare-ocs-deviceset are running', () => {


Suggested change

it('tests if 3 rook-ceph-osd-prepare-ocs-deviceset are running', () => {

it('tests if 3 rook-ceph-osd-prepare-ocs-deviceset are completed', () => {

gnehapk · 2020-05-14T04:55:53Z

/lgtm

openshift-ci-robot · 2020-05-14T04:56:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, ebondare, gnehapk, shyRozen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [bipuladh,gnehapk,shyRozen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-05-14T07:07:03Z

@bipuladh: This pull request references Bugzilla bug 1835597, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1835597: Add easier way to support selectors for multiple versions in OCS Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-05-14T07:07:09Z

@bipuladh: This pull request references Bugzilla bug 1835597, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2020-05-14T07:07:36Z

/bugzilla refresh

openshift-ci-robot · 2020-05-14T07:07:42Z

@bipuladh: This pull request references Bugzilla bug 1835597, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-05-14T07:08:46Z

@bipuladh: This pull request references Bugzilla bug 1835597, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2020-05-14T07:09:19Z

/bugzilla refresh

openshift-ci-robot · 2020-05-14T07:09:24Z

@bipuladh: This pull request references Bugzilla bug 1835597, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-05-14T10:19:05Z

@bipuladh: All pull requests linked via external trackers have merged: openshift/console#5137. Bugzilla bug 1835597 has been moved to the MODIFIED state.

In response to this:

Bug 1835597: Add easier way to support selectors for multiple versions in OCS Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/ceph Related to ceph-storage-plugin labels Apr 21, 2020

openshift-ci-robot requested review from a2batic and afreen23 April 21, 2020 20:08

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2020

gnehapk mentioned this pull request Apr 27, 2020

Bug 1841470: Added ocp e2e tests for add capacity #5194

Merged

bipuladh force-pushed the tests_upgrade branch from 40b9d68 to 70482cc Compare April 28, 2020 13:36

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2020

bipuladh changed the title ~~[WIP]: Add easier way to support selectors for multiple versions in OCS Tests~~ Add easier way to support selectors for multiple versions in OCS Tests Apr 28, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2020

gnehapk reviewed May 7, 2020

View reviewed changes

frontend/packages/ceph-storage-plugin/integration-tests/views/installFlow.view.ts Show resolved Hide resolved

shyRozen approved these changes May 7, 2020

View reviewed changes

ebondare approved these changes May 7, 2020

View reviewed changes

bipuladh force-pushed the tests_upgrade branch from 70482cc to aabba5a Compare May 12, 2020 06:34

bipuladh requested a review from gnehapk May 12, 2020 06:38

gnehapk approved these changes May 12, 2020

View reviewed changes

bipuladh force-pushed the tests_upgrade branch from aabba5a to 427ea61 Compare May 13, 2020 07:33

gnehapk reviewed May 13, 2020

View reviewed changes

bipuladh force-pushed the tests_upgrade branch from 427ea61 to e8cee47 Compare May 14, 2020 04:02

gnehapk reviewed May 14, 2020

View reviewed changes

Add easier way to support selectors for multiple versions in OCS Tests

8b8066c

bipuladh force-pushed the tests_upgrade branch from e8cee47 to 8b8066c Compare May 14, 2020 04:12

openshift-ci-robot assigned gnehapk May 14, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2020

bipuladh changed the title ~~Add easier way to support selectors for multiple versions in OCS Tests~~ Bug 1835597: Add easier way to support selectors for multiple versions in OCS Tests May 14, 2020

openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 14, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 14, 2020

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels May 14, 2020

openshift-merge-robot merged commit 52d2728 into openshift:master May 14, 2020

spadgett added this to the v4.5 milestone May 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1835597: Add easier way to support selectors for multiple versions in OCS Tests #5137

Bug 1835597: Add easier way to support selectors for multiple versions in OCS Tests #5137

bipuladh commented Apr 21, 2020

bipuladh commented Apr 21, 2020

bipuladh commented Apr 21, 2020

bipuladh commented Apr 28, 2020

bipuladh commented Apr 28, 2020

bipuladh commented May 5, 2020

gnehapk May 7, 2020

gnehapk May 7, 2020

gnehapk May 7, 2020

bipuladh May 7, 2020

gnehapk May 7, 2020

gnehapk commented May 8, 2020

gnehapk May 13, 2020

bipuladh May 13, 2020

gnehapk commented May 13, 2020

gnehapk May 14, 2020

gnehapk commented May 14, 2020

openshift-ci-robot commented May 14, 2020

openshift-ci-robot commented May 14, 2020

openshift-ci-robot commented May 14, 2020

bipuladh commented May 14, 2020

openshift-ci-robot commented May 14, 2020

openshift-ci-robot commented May 14, 2020

bipuladh commented May 14, 2020

openshift-ci-robot commented May 14, 2020

openshift-ci-robot commented May 14, 2020

	const link = $(`article:nth-child(${index + 1}) a`);
	return $(`article:nth-child(${index + 1}) a`);

		@@ -130,78 +157,39 @@ export class InstallCluster {
		this.namespace = namespace;

	it('tests if 3 rook-ceph-osd-prepare-ocs-deviceset are running', () => {
	it('tests if 3 rook-ceph-osd-prepare-ocs-deviceset are completed', () => {

Bug 1835597: Add easier way to support selectors for multiple versions in OCS Tests #5137

Bug 1835597: Add easier way to support selectors for multiple versions in OCS Tests #5137

Conversation

bipuladh commented Apr 21, 2020

bipuladh commented Apr 21, 2020

bipuladh commented Apr 21, 2020

bipuladh commented Apr 28, 2020

bipuladh commented Apr 28, 2020

bipuladh commented May 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnehapk commented May 8, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnehapk commented May 13, 2020

Choose a reason for hiding this comment

gnehapk commented May 14, 2020

openshift-ci-robot commented May 14, 2020

openshift-ci-robot commented May 14, 2020

openshift-ci-robot commented May 14, 2020

bipuladh commented May 14, 2020

openshift-ci-robot commented May 14, 2020

openshift-ci-robot commented May 14, 2020

bipuladh commented May 14, 2020

openshift-ci-robot commented May 14, 2020

openshift-ci-robot commented May 14, 2020