Bug 1826526: Improves Start Pipeline Resource section

[andrewballantyne]

Fixes:
https://issues.redhat.com/browse/ODC-3405

Analysis / Root cause:
Pipeline Resources section was not ideal.

Solution Description:
Disable the dropdown when no items are selectable & space the content out more.

Screen shots / Gifs for design review:

@openshift/team-devconsole-ux

Before (when the ticket was logged - used the cluster directly):

After (with Triggers work + this PR):

Test setup:

• Pipeline Operator
• Pipeline needing resources
• Start Modal action with no Pipeline Resources created (to force the initial empty state)

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@andrewballantyne: This pull request references Bugzilla bug 1826526, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1826526: Improves Start Pipeline Resource section

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@andrewballantyne: This pull request references Bugzilla bug 1826526, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1826526: Improves Start Pipeline Resource section

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@andrewballantyne: An error was encountered searching for bug 1826526 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1826526?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1826526: Improves Start Pipeline Resource section

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andrewballantyne]

/bugzilla refresh

[openshift-ci-robot]

@andrewballantyne: This pull request references Bugzilla bug 1826526, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[divyanshiGupta]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, divyanshiGupta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[serenamarie125]

@andrewballantyne can you add an explanation as to why we couldn't use the internal form pattern that we are using in other areas? I think it would be good to have that noted, so there's an understanding of why we deviated and are not consistent.

[andrewballantyne]

@andrewballantyne can you add an explanation as to why we couldn't use the internal form pattern that we are using in other areas? I think it would be good to have that noted, so there's an understanding of why we deviated and are not consistent.

@serenamarie125 Sure, two main points I have for why I made this change in 4.5 (separate of this PR for clarity):

1. If you create an inline Pipeline Resource and then cancel your Start Modal you end up with this extra resource hanging around... thus defeating the "modal and inline" form like action.
   • Note Secrets are currently this way and will need to be changed in 4.6 with a little refactor
2. Biggest problem and the one that lead the change, is Triggers. Triggers can create resources off of parameters and those parameters cannot be isolated away in a separate created CR object as there is no reference for the Operator to make use of those params during "trigger occurance"

I tried for several hours to reuse what we had, but due to the inline desires of creation and how we display dropdown items, it just became this web of mess. Essentially it boiled down to either I copy the logic and duplicate code for Triggers or make the change and improve both Modals. I chose the latter because of no.1 above (and code quality / consistency).

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@andrewballantyne: All pull requests linked via external trackers have merged: openshift/console#5140. Bugzilla bug 1826526 has been moved to the MODIFIED state.

In response to this:

Bug 1826526: Improves Start Pipeline Resource section

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.