Bug 1828611: Add events for Noobaa for activity card #5142

a2batic · 2020-04-22T06:52:18Z

Add events for Noobaa Backing store, Noobaa Bucket class, OBC and OB for Object dashboard activity card

Fixes: https://issues.redhat.com/browse/RHSTOR-1022
Signed-off-by: Kanika kmurarka@redhat.com

rawagner · 2020-04-22T06:56:52Z

frontend/packages/noobaa-storage-plugin/src/components/activity-card/activity-card.tsx


 const eventsResource: FirehoseResource = { isList: true, kind: EventModel.kind, prop: 'events' };

 const isNoobaaEventObject = (event: EventKind): boolean => {
  const eventName: string = _.get(event, 'involvedObject.name');
-  return _.startsWith(eventName, 'noobaa');
+  const component: string = _.get(event, 'source.component');


optional chaining is preferred, even for the line below

rawagner · 2020-04-23T06:53:03Z

/lgtm

afreen23 · 2020-04-24T10:39:31Z

/retitle Add events for Noobaa for activity card

afreen23 · 2020-04-24T11:16:16Z

/bugzilla refresh

openshift-ci-robot · 2020-04-24T11:16:17Z

@afreen23: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2020-04-24T11:17:43Z

/retest

afreen23 · 2020-04-24T14:11:21Z

/test

openshift-ci-robot · 2020-04-24T14:11:38Z

@afreen23: The /test command needs one or more targets.
The following commands are available to trigger jobs:

/test analyze
/test backend
/test e2e-gcp-console
/test frontend
/test images

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23 · 2020-04-24T14:11:57Z

/test all

afreen23 · 2020-04-24T14:17:14Z

/lgtm cancel

Just to fix this, cancelling.

afreen23 · 2020-04-24T14:22:31Z

frontend/packages/noobaa-storage-plugin/src/components/activity-card/activity-card.tsx

 import { DATA_RESILIENCE_QUERIES } from '../../queries';
 import './activity-card.scss';
+import { NooBaaBackingStoreModel, NooBaaBucketClassModel } from '../../models';


Nit:
Can you fix the order of imports ?

afreen23 · 2020-04-24T14:35:00Z

frontend/packages/noobaa-storage-plugin/src/components/activity-card/activity-card.tsx

+  if (
+    eventKind === PodModel.kind ||
+    eventKind === StatefulSetModel.kind ||
+    eventKind === NooBaaBackingStoreModel.kind ||


Backing store is a Noobaa entity, isNoobaaEventObject(event) can be avoided for this.

afreen23 · 2020-04-27T07:30:38Z

frontend/packages/noobaa-storage-plugin/src/components/activity-card/activity-card.tsx

+  const eventKind: string = event?.involvedObject?.kind;
+  return (
+    _.startsWith(eventName, 'noobaa') ||
+    _.startsWith(component, 'noobaa') ||


Why are we using component and eventName both here ?

afreen23 · 2020-04-27T07:38:06Z

frontend/packages/noobaa-storage-plugin/src/components/activity-card/activity-card.tsx

+import {
+  NooBaaBackingStoreModel,
+  NooBaaBucketClassModel,
+  NooBaaObjectBucketClaimModel,
+} from '../../models';


Suggested change

import {

NooBaaBackingStoreModel,

NooBaaBucketClassModel,

NooBaaObjectBucketClaimModel,

} from '../../models';

import {

NooBaaBackingStoreModel,

NooBaaBucketClassModel,

NooBaaObjectBucketClaimModel,

} from '../../models';

import './activity-card.scss';

afreen23 · 2020-04-27T14:39:54Z

frontend/packages/noobaa-storage-plugin/src/components/activity-card/activity-card.tsx

+const otherNoobaaEvents = (event: EventKind): boolean => {
+  const eventKind: string = event?.involvedObject?.kind;
+  return (
+    eventKind === NooBaaBackingStoreModel.kind ||
+    eventKind === NooBaaBucketClassModel.kind ||
+    eventKind === NooBaaObjectBucketClaimModel.kind
+  );
+};
+


const noobaaResources = [ NooBaaBackingStoreModel.kind, NooBaaBucketClassModel.kind , NooBaaObjectBucketClaimModel.kind];

afreen23 · 2020-04-27T14:53:21Z

frontend/packages/noobaa-storage-plugin/src/components/activity-card/activity-card.tsx

+  if (otherNoobaaEvents(event)) {
+    return true;
+  }
  return false;


Suggested change

if (otherNoobaaEvents(event)) {

return true;

}

return false;

return noobaaResources.includes(eventKind)

a2batic · 2020-04-27T22:09:43Z

/retitle Bug 1828611: Add events for Noobaa for activity card

openshift-ci-robot · 2020-04-27T22:10:03Z

@a2batic: This pull request references Bugzilla bug 1828611, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1828611: Add events for Noobaa for activity card

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-28T13:16:23Z

@a2batic: This pull request references Bugzilla bug 1828611, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1828611: Add events for Noobaa for activity card

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

for Object dashboard activity card Signed-off-by: Kanika <kmurarka@redhat.com>

afreen23 · 2020-04-29T04:38:09Z

/bugzilla refresh

openshift-ci-robot · 2020-04-29T04:38:13Z

@afreen23: This pull request references Bugzilla bug 1828611, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afreen23

/lgtm

openshift-ci-robot · 2020-04-29T04:50:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, afreen23, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/noobaa-storage-plugin/OWNERS~~ [afreen23,rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-04-29T06:18:21Z

@a2batic: All pull requests linked via external trackers have merged: openshift/console#5142. Bugzilla bug 1828611 has been moved to the MODIFIED state.

In response to this:

Bug 1828611: Add events for Noobaa for activity card

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the component/noobaa Related to noobaa-storage-plugin label Apr 22, 2020

openshift-ci-robot requested review from cloudbehl and rawagner April 22, 2020 06:52

rawagner reviewed Apr 22, 2020

View reviewed changes

a2batic force-pushed the noobaa-activity-card branch from 572af20 to 334680d Compare April 22, 2020 19:53

a2batic requested a review from rawagner April 23, 2020 06:41

openshift-ci-robot assigned rawagner Apr 23, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 23, 2020

openshift-ci-robot changed the title ~~Bug: Add events for Noobaa for activity card~~ Add events for Noobaa for activity card Apr 24, 2020

openshift-ci-robot assigned afreen23 Apr 24, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2020

afreen23 reviewed Apr 24, 2020

View reviewed changes

afreen23 suggested changes Apr 24, 2020

View reviewed changes

a2batic force-pushed the noobaa-activity-card branch from 334680d to ee10fd4 Compare April 26, 2020 21:05

afreen23 reviewed Apr 27, 2020

View reviewed changes

a2batic force-pushed the noobaa-activity-card branch 2 times, most recently from f3a07ac to 5cc5fc4 Compare April 27, 2020 12:55

afreen23 suggested changes Apr 27, 2020

View reviewed changes

openshift-ci-robot changed the title ~~Add events for Noobaa for activity card~~ Bug 1828611: Add events for Noobaa for activity card Apr 27, 2020

openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Apr 27, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 27, 2020

a2batic force-pushed the noobaa-activity-card branch from 5cc5fc4 to 363e8aa Compare April 28, 2020 13:14

Add events for Noobaa Backing store and Noobaa Bucket class

7ba31ac

for Object dashboard activity card Signed-off-by: Kanika <kmurarka@redhat.com>

a2batic force-pushed the noobaa-activity-card branch from 363e8aa to 7ba31ac Compare April 28, 2020 18:27

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Apr 29, 2020

afreen23 approved these changes Apr 29, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2020

openshift-merge-robot merged commit d7542c5 into openshift:master Apr 29, 2020

spadgett added this to the v4.5 milestone Apr 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1828611: Add events for Noobaa for activity card #5142

Bug 1828611: Add events for Noobaa for activity card #5142

a2batic commented Apr 22, 2020 •

edited

rawagner Apr 22, 2020

rawagner commented Apr 23, 2020

afreen23 commented Apr 24, 2020

afreen23 commented Apr 24, 2020

openshift-ci-robot commented Apr 24, 2020

afreen23 commented Apr 24, 2020

afreen23 commented Apr 24, 2020

openshift-ci-robot commented Apr 24, 2020

afreen23 commented Apr 24, 2020

afreen23 commented Apr 24, 2020

afreen23 Apr 24, 2020

afreen23 Apr 24, 2020

afreen23 Apr 27, 2020

afreen23 Apr 27, 2020

afreen23 Apr 27, 2020

afreen23 Apr 27, 2020

a2batic commented Apr 27, 2020

openshift-ci-robot commented Apr 27, 2020

openshift-ci-robot commented Apr 28, 2020

afreen23 commented Apr 29, 2020

openshift-ci-robot commented Apr 29, 2020

afreen23 left a comment

openshift-ci-robot commented Apr 29, 2020

openshift-ci-robot commented Apr 29, 2020

Bug 1828611: Add events for Noobaa for activity card #5142

Bug 1828611: Add events for Noobaa for activity card #5142

Conversation

a2batic commented Apr 22, 2020 • edited

rawagner Apr 22, 2020

Choose a reason for hiding this comment

rawagner commented Apr 23, 2020

afreen23 commented Apr 24, 2020

afreen23 commented Apr 24, 2020

openshift-ci-robot commented Apr 24, 2020

afreen23 commented Apr 24, 2020

afreen23 commented Apr 24, 2020

openshift-ci-robot commented Apr 24, 2020

afreen23 commented Apr 24, 2020

afreen23 commented Apr 24, 2020

afreen23 Apr 24, 2020

Choose a reason for hiding this comment

afreen23 Apr 24, 2020

Choose a reason for hiding this comment

afreen23 Apr 27, 2020

Choose a reason for hiding this comment

afreen23 Apr 27, 2020

Choose a reason for hiding this comment

afreen23 Apr 27, 2020

Choose a reason for hiding this comment

afreen23 Apr 27, 2020

Choose a reason for hiding this comment

a2batic commented Apr 27, 2020

openshift-ci-robot commented Apr 27, 2020

openshift-ci-robot commented Apr 28, 2020

afreen23 commented Apr 29, 2020

openshift-ci-robot commented Apr 29, 2020

afreen23 left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Apr 29, 2020

openshift-ci-robot commented Apr 29, 2020

a2batic commented Apr 22, 2020 •

edited