New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1826933: Show helm chart icon in group label in topology #5155
Bug 1826933: Show helm chart icon in group label in topology #5155
Conversation
@rohitkrai03: This pull request references Bugzilla bug 1826933, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @openshift/team-ux-review |
/retest |
1 similar comment
/retest |
/lgtm |
/assign @christianvogt |
260dd51
to
b12df04
Compare
/lgtm |
} | ||
}; | ||
|
||
export const isIconBase64Encoded = (iconData: string): boolean => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed anymore?
isIconUrl
will accept data encoded values.
b12df04
to
144a37a
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rohitkrai03: All pull requests linked via external trackers have merged: openshift/console#5155. Bugzilla bug 1826933 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes - https://issues.redhat.com/browse/ODC-3154
Screencast -