New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1827291: Fix bad websocket url error due to fetching of resourcea when not required #5170
Bug 1827291: Fix bad websocket url error due to fetching of resourcea when not required #5170
Conversation
@rohitkrai03: An error was encountered adding this pull request to the external tracker bugs for bug 1827291 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@rohitkrai03: This pull request references Bugzilla bug 1827291, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I find it odd that (unrelated to your work here) we allow an /import/all-namespaces
route to exist.
cc @christianvogt not sure if we want to look to remove this or if it was added for a specific reason.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Well, it was added at the time of 4.2 when we had a project selector dropdown in the form itself. So opening import form with all-namespaces would let you choose the project directly in the form. But then we changed all that and it's not required now. So maybe we can look at removing it. |
@rohitkrai03 can you log a refactor task? |
/retest |
1 similar comment
/retest |
@andrewballantyne Added a bug in Jira - https://issues.redhat.com/browse/ODC-3672 |
/retest |
@rohitkrai03: All pull requests linked via external trackers have merged: openshift/console#5170. Bugzilla bug 1827291 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@spadgett: Bugzilla bug 1827291 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes - https://issues.redhat.com/browse/ODC-3503