New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1828777: fix(prun): rerun pipeline run #5181
Bug 1828777: fix(prun): rerun pipeline run #5181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -76,6 +76,7 @@ export const getPipelineRunData = ( | |||
resources, | |||
...(params && { params }), | |||
workspaces, | |||
status: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the only purpose of this field is currently to cancel the Pipeline. I think this is a fine solution.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinandan13jan, andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle Bug 1828777: fix(prun): rerun pipeline run |
@abhinandan13jan: This pull request references Bugzilla bug 1828777, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abhinandan13jan: All pull requests linked via external trackers have merged: openshift/console#5181. Bugzilla bug 1828777 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abhinandan13jan: Bugzilla bug 1828777 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
Addresses https://issues.redhat.com/browse/ODC-3526
https://bugzilla.redhat.com/show_bug.cgi?id=1828777
Analysis / Root cause:
Rerunning cancelled pipelinerun doesn't work
Solution Description:
Added status field as null which was added as PipelineRunCancelled...hence it never started
Screenshot
Browser conformation
Chrome 73