Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1828055: fix affinity-row select component #5189

Merged
merged 1 commit into from Apr 30, 2020
Merged

Bug 1828055: fix affinity-row select component #5189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...ing-modals/affinity-modal/components/affinity-expression-list/affinity-expression-row.tsx
View file
Open in desktop
Expand Up @@ -8,6 +8,7 @@ import {
FormSelectOption,
Select,
SelectVariant,
SelectOption,
} from '@patternfly/react-core';
import { EXPRESSION_OPERATORS } from '../../../shared/consts';
import { AffinityLabel } from '../../types';
Expand All @@ -34,6 +35,7 @@ export const AffinityExpressionRow = ({
<>
<GridItem span={4}>
<TextInput
id={`affinity-${id}-key-input`}
className="kv-affinity-expression-row__key-input"
placeholder="key"
isRequired
Expand All @@ -45,6 +47,7 @@ export const AffinityExpressionRow = ({
</GridItem>
<GridItem span={2}>
<FormSelect
id={`affinity-${id}-effect-select`}
className="kv-affinity-expression-row__operator-input"
isRequired
value={operator}
Expand All @@ -69,10 +72,15 @@ export const AffinityExpressionRow = ({
selections={enableValueField ? values : []}
ariaLabelledBy="values select"
placeholderText={enableValueField ? 'Enter Value' : ''}
/>
>
{values.map((option, index) => (
// eslint-disable-next-line react/no-array-index-key
<SelectOption isDisabled={false} key={index} value={option} />
))}
</Select>
</GridItem>
<GridItem span={1}>
<Button id={`${key}-delete-btn`} onClick={() => onDelete(id)} variant="plain">
<Button id={`affinity-${id}-delete-btn`} onClick={() => onDelete(id)} variant="plain">
<MinusCircleIcon />
</Button>
</GridItem>
Expand Down