Bug 1829647: Monitoring: Silence details page: Display - when no Firing Alerts
#5206
Conversation
When the silence did not match any alerts, the Firing Alerts field was blank. It should display `-` instead.
openshift-ci-robot
added
component/core
| @@ -418,7 +422,7 @@ const SilenceTableRow: RowFunction<Silence> = ({ index, key, obj, style }) => { | |||
| </div> | |||
| </TableData> | |||
| <TableData className={tableSilenceClasses[1]}> | |||
| {_.isEmpty(firingAlerts) ? '-' : <SeverityCounts alerts={firingAlerts} />} | |||
| <SeverityCounts alerts={firingAlerts} /> | |||
There was a problem hiding this comment.
- was already shown on the silence list page, so moved that into SeverityCounts so that it also applies to the details page.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kyoto
changed the title
- when no Firing Alerts- when no Firing Alerts
openshift-ci-robot
added
the
bugzilla/severity-unspecified
|
@kyoto: This pull request references Bugzilla bug 1829647, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@kyoto: All pull requests linked via external trackers have merged: openshift/console#5206. Bugzilla bug 1829647 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When the silence did not match any alerts, the Firing Alerts field was
blank. It should display
-instead.