Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1828703: Task listing improvements on Pipeline detail page #5208

Merged
merged 1 commit into from May 6, 2020
Merged

Bug 1828703: Task listing improvements on Pipeline detail page #5208

merged 1 commit into from May 6, 2020

Conversation

karthikjeeyar
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-3651

Analysis / Root cause:
pipeline details page should showcase the tasks with a custom displayName in the task section

Solution Description:
included displayName property in dynamicResourceLink component to accept the custom names for the tasks.

Screen shots / Gifs for design review:
image

Unit test/ Test coverage:

image

Browser Conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

cc: @serenamarie125 @openshift/team-devconsole-ux

/kind bug

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

@karthikjeeyar: This pull request references Bugzilla bug 1828703, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1828703: Task listing improvements on Pipeline detail page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 28, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Apr 28, 2020
@karthikjeeyar
Copy link
Contributor Author

/retest

2 similar comments
@karthikjeeyar
Copy link
Contributor Author

/retest

@karthikjeeyar
Copy link
Contributor Author

/retest

sahil143
sahil143 approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
verified changes locally

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2020
@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, karthikjeeyar, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit a2919b3 into openshift:master May 6, 2020
@openshift-ci-robot
Copy link
Contributor

@karthikjeeyar: All pull requests linked via external trackers have merged: openshift/console#5208. Bugzilla bug 1828703 has been moved to the MODIFIED state.

In response to this:

Bug 1828703: Task listing improvements on Pipeline detail page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil143 sahil143 sahil143 approved these changes

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

Assignees

@sahil143 sahil143

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@karthikjeeyar @openshift-ci-robot @christianvogt @sahil143 @spadgett @openshift-merge-robot