Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1828791: Fix pipeline bar unnecessary animations #5211

Merged
merged 1 commit into from Apr 28, 2020
Merged

Bug 1828791: Fix pipeline bar unnecessary animations #5211

merged 1 commit into from Apr 28, 2020

Conversation

rohitkrai03
Copy link
Contributor

Fixes - https://issues.redhat.com/browse/ODC-2564

  • This PR adds a key to the PipelineTaskStatus component to stop it from reanimating when data changes from firehose or when the list is sorted.

Screencast -
Peek 2020-04-28 16-53

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

@rohitkrai03: This pull request references Bugzilla bug 1828791, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1828791: Fix pipeline bar unnecessary animations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 28, 2020
@rohitkrai03
Copy link
Contributor Author

/retest

@rohitkrai03
Copy link
Contributor Author

/assign @andrewballantyne

andrewballantyne
andrewballantyne suggested changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test this once I get through my emails... almost there. But this looks like the solution I came up with as well.

frontend/packages/dev-console/src/components/pipelineruns/status/PipelineBars.tsx Show resolved Hide resolved
...tend/packages/dev-console/src/components/pipelineruns/status/LinkedPipelineRunTaskStatus.tsx Outdated Show resolved Hide resolved
frontend/packages/dev-console/src/components/pipelineruns/status/PipelineTaskStatus.tsx Outdated Show resolved Hide resolved
@rohitkrai03 rohitkrai03 force-pushed the pipeline-bar-fix branch 2 times, most recently from d500a01 to 0095696 Compare April 28, 2020 18:05
andrewballantyne
andrewballantyne approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested both the Pipeline list and Pipeline Run list pages as well as the Pipeline Details, Pipeline Runs tab. Looks like this solution fixes all the issues with the animation occurring on sort / filter.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 774ce54 into openshift:master Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

@rohitkrai03: All pull requests linked via external trackers have merged: openshift/console#5211. Bugzilla bug 1828791 has been moved to the MODIFIED state.

In response to this:

Bug 1828791: Fix pipeline bar unnecessary animations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Apr 29, 2020
@rohitkrai03 rohitkrai03 deleted the pipeline-bar-fix branch July 24, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

Assignees

@andrewballantyne andrewballantyne

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rohitkrai03 @openshift-ci-robot @andrewballantyne @spadgett @openshift-merge-robot