New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1828958: Fix handling of Operand conditions #5232
Bug 1828958: Fix handling of Operand conditions #5232
Conversation
@spadgett: This pull request references Bugzilla bug 1828958, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unassign @benjaminapetersen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much win! A few typos, but otherwise lgtm.
|
||
it('dispalys the correct status and status type for a status value of running', () => { | ||
it('dispalys the correct status a `status` value of `Running`', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it('dispalys the correct status a `status` value of `Running`', () => { | |
it('displays the correct status for a `status` value of `Running`', () => { |
expect(wrapper.childAt(2).props().title).toEqual('Running'); | ||
}); | ||
|
||
it('displays the correct status and status type for a phase value of running', () => { | ||
it('displays the correct status a `phase` value of `Running`', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it('displays the correct status a `phase` value of `Running`', () => { | |
it('displays the correct status for a `phase` value of `Running`', () => { |
expect(wrapper.childAt(2).props().title).toEqual('Running'); | ||
}); | ||
|
||
it('displays Unknown for a missing or unknown status object', () => { | ||
it('displays the correct status a `phase` value of `Running`', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it('displays the correct status a `phase` value of `Running`', () => { | |
it('displays the correct status for a `phase` value of `Running`', () => { |
d77b402
to
eee26af
Compare
Check `condition.status` before showing a condition as the operand status.
eee26af
to
4acfa91
Compare
thanks @rhamilto 👍 updated |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@spadgett: All pull requests linked via external trackers have merged: openshift/console#5232. Bugzilla bug 1828958 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spadgett: #5232 failed to apply on top of branch "release-4.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Check
condition.status
before using a condition as the operand status. Also make surephase
,status
, orstate
are strings before displaying them./assign @benjaminapetersen