Bug 1834186: Change Input of Independent Mode to Text Area from Text Input #5241

bipuladh · 2020-04-30T11:29:08Z

Screenshots
Before File Upload:

After File Upload:

UXD
https://marvelapp.com/da7ai67/screen/65092932

frontend/packages/ceph-storage-plugin/src/components/independent-mode/utils.ts

gnehapk · 2020-05-07T04:39:38Z

@bipuladh Can you please add the screenshot of the view once the json file is uploaded. Wants to see how it looks after uploading.

gnehapk · 2020-05-07T04:51:50Z

UXD - https://marvelapp.com/da7ai67/screen/65092932

frontend/packages/ceph-storage-plugin/src/components/independent-mode/utils.ts

frontend/packages/ceph-storage-plugin/src/components/independent-mode/install.tsx

cloudbehl · 2020-05-07T06:18:06Z

frontend/packages/ceph-storage-plugin/src/components/independent-mode/install.tsx

@@ -143,40 +99,15 @@ const InstallExternalCluster = withHandlePromise((props: InstallExternalClusterP
      .catch((e) => {
        // eslint-disable-next-line no-console
        console.error(e);
+        // Remove secret if cluster creation was not possible
+        handlePromise(k8sKill(SecretModel, secret));


frontend/packages/ceph-storage-plugin/src/components/independent-mode/utils.ts

cloudbehl · 2020-05-07T06:24:04Z

frontend/packages/ceph-storage-plugin/src/components/independent-mode/utils.ts

@@ -30,6 +59,11 @@ export const checkForIndependentSupport = (csv: ClusterServiceVersionKind): bool
  return independent === 'true';
 };

+export const getRequiredKeys = (csv: ClusterServiceVersionKind): string[] => {
+  const keys = csv.metadata.annotations?.['external.cluster.ocs.openshift.io/keys'];
+  return keys?.split(',');


are you expecting keys to be a string?

similar to the feature annotation so yes.

sounds good!

cloudbehl · 2020-05-07T09:52:07Z

frontend/packages/ceph-storage-plugin/src/components/independent-mode/utils.ts

@@ -30,6 +59,11 @@ export const checkForIndependentSupport = (csv: ClusterServiceVersionKind): bool
  return independent === 'true';
 };

+export const getRequiredKeys = (csv: ClusterServiceVersionKind): string[] => {
+  const keys = csv.metadata.annotations?.['external.cluster.ocs.openshift.io/keys'];
+  return keys?.split(',');


sounds good!

frontend/packages/ceph-storage-plugin/src/components/independent-mode/utils.ts

cloudbehl · 2020-05-08T08:05:43Z

You haven't added this to the independent mode request?

  crashCollector:
    disable: true

bipuladh · 2020-05-08T08:35:42Z

You haven't added this to the independent mode request?
  crashCollector:
    disable: true

I don't see it used anywhere else. Is it documented anywhere?

cloudbehl · 2020-05-08T11:10:42Z

Please check the document by Sebastian.

cloudbehl · 2020-05-11T06:53:32Z

@bipuladh add bugzilla!

frontend/packages/ceph-storage-plugin/src/components/ocs-install/install-page.tsx

cloudbehl

NIT

cloudbehl · 2020-05-12T09:31:05Z

frontend/packages/ceph-storage-plugin/src/components/ocs-install/install-page.tsx

              />
            </div>
          </div>
        )}
        {(isIndependent === false || mode === MODES.CONVERGED) && (
          <CreateOCSServiceForm match={match} />
        )}
-        {mode === MODES.INDEPENDENT && <InstallExternalCluster match={match} />}
+        {mode === MODES.INDEPENDENT && independentReqdKeys && downloadFile && (


downloadFile should not be a hard requirement.

Not doing this is a source of bug.

a2batic · 2020-05-12T09:57:11Z

/lgtm

bipuladh · 2020-05-12T10:07:15Z

/hold needs to be in sync with red-hat-storage/ocs-operator#499

bipuladh · 2020-05-12T11:49:38Z

/bugzilla refresh

openshift-ci-robot · 2020-05-12T11:49:42Z

@bipuladh: This pull request references Bugzilla bug 1834186, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2020-05-14T07:14:33Z

/hold cancel

cloudbehl · 2020-05-14T07:15:18Z

/lgtm

openshift-ci-robot · 2020-05-14T07:15:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, bipuladh, cloudbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/ceph-storage-plugin/OWNERS~~ [bipuladh,cloudbehl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-05-14T08:42:47Z

@bipuladh: All pull requests linked via external trackers have merged: openshift/console#5241. Bugzilla bug 1834186 has been moved to the MODIFIED state.

In response to this:

Bug 1834186: Change Input of Independent Mode to Text Area from Text Input

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2020

openshift-ci-robot requested review from a2batic and cloudbehl April 30, 2020 11:29

openshift-ci-robot added component/ceph Related to ceph-storage-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 30, 2020

bipuladh force-pushed the indep_mode_design branch from 004ed22 to c045b39 Compare May 6, 2020 20:29

bipuladh changed the title ~~[WIP] Change Input of Indepent Mode to Text Area from Text Input~~ Change Input of Indepent Mode to Text Area from Text Input May 6, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2020

bipuladh changed the title ~~Change Input of Indepent Mode to Text Area from Text Input~~ Change Input of Independent Mode to Text Area from Text Input May 6, 2020

gnehapk reviewed May 7, 2020

View reviewed changes

frontend/packages/ceph-storage-plugin/src/components/independent-mode/utils.ts Outdated Show resolved Hide resolved

gnehapk reviewed May 7, 2020

View reviewed changes

frontend/packages/ceph-storage-plugin/src/components/independent-mode/utils.ts Show resolved Hide resolved

cloudbehl suggested changes May 7, 2020

View reviewed changes

cloudbehl reviewed May 7, 2020

View reviewed changes

bipuladh force-pushed the indep_mode_design branch from c045b39 to 0a82b98 Compare May 7, 2020 16:00

bipuladh requested review from gnehapk and cloudbehl May 7, 2020 19:34

cloudbehl reviewed May 8, 2020

View reviewed changes

frontend/packages/ceph-storage-plugin/src/components/independent-mode/utils.ts Outdated Show resolved Hide resolved

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2020

bipuladh force-pushed the indep_mode_design branch from 0a82b98 to 8d28afc Compare May 11, 2020 04:31

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2020

bipuladh requested a review from cloudbehl May 11, 2020 04:31

bipuladh force-pushed the indep_mode_design branch 2 times, most recently from 4c9019e to 3d6ef49 Compare May 11, 2020 09:09

bipuladh changed the title ~~Change Input of Independent Mode to Text Area from Text Input~~ Bug 1834186: Change Input of Independent Mode to Text Area from Text Input May 11, 2020

bipuladh force-pushed the indep_mode_design branch from 3d6ef49 to 7b64605 Compare May 12, 2020 05:33

cloudbehl approved these changes May 12, 2020

View reviewed changes

bipuladh force-pushed the indep_mode_design branch from 7b64605 to 21cc9f7 Compare May 12, 2020 06:44

a2batic suggested changes May 12, 2020

View reviewed changes

frontend/packages/ceph-storage-plugin/src/components/ocs-install/install-page.tsx Show resolved Hide resolved

bipuladh force-pushed the indep_mode_design branch from 21cc9f7 to 234cbec Compare May 12, 2020 09:28

cloudbehl reviewed May 12, 2020

View reviewed changes

bipuladh force-pushed the indep_mode_design branch from 234cbec to 21a2de2 Compare May 12, 2020 09:45

bipuladh requested a review from a2batic May 12, 2020 09:47

openshift-ci-robot assigned a2batic May 12, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels May 12, 2020

Update Independent Mode Installation flow

1d82c6f

bipuladh force-pushed the indep_mode_design branch from 21a2de2 to 1d82c6f Compare May 13, 2020 07:08

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 13, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2020

openshift-ci-robot assigned cloudbehl May 14, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2020

openshift-merge-robot merged commit 4a1b0e4 into openshift:master May 14, 2020

spadgett added this to the v4.5 milestone May 18, 2020

openshift-ci-robot mentioned this pull request May 27, 2020

Bug 1834186: Update validation annotation used by the UI red-hat-storage/ocs-operator#519

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1834186: Change Input of Independent Mode to Text Area from Text Input #5241

Bug 1834186: Change Input of Independent Mode to Text Area from Text Input #5241

bipuladh commented Apr 30, 2020 •

edited

gnehapk commented May 7, 2020 •

edited

gnehapk commented May 7, 2020

cloudbehl May 7, 2020

cloudbehl May 7, 2020

bipuladh May 7, 2020

cloudbehl May 7, 2020

cloudbehl May 7, 2020

cloudbehl commented May 8, 2020

bipuladh commented May 8, 2020

cloudbehl commented May 8, 2020

cloudbehl commented May 11, 2020

cloudbehl left a comment

cloudbehl May 12, 2020

bipuladh May 12, 2020

a2batic commented May 12, 2020

bipuladh commented May 12, 2020

bipuladh commented May 12, 2020

openshift-ci-robot commented May 12, 2020

bipuladh commented May 14, 2020

cloudbehl commented May 14, 2020

openshift-ci-robot commented May 14, 2020

openshift-ci-robot commented May 14, 2020

Bug 1834186: Change Input of Independent Mode to Text Area from Text Input #5241

Bug 1834186: Change Input of Independent Mode to Text Area from Text Input #5241

Conversation

bipuladh commented Apr 30, 2020 • edited

gnehapk commented May 7, 2020 • edited

gnehapk commented May 7, 2020

cloudbehl May 7, 2020

Choose a reason for hiding this comment

cloudbehl May 7, 2020

Choose a reason for hiding this comment

bipuladh May 7, 2020

Choose a reason for hiding this comment

cloudbehl May 7, 2020

Choose a reason for hiding this comment

cloudbehl May 7, 2020

Choose a reason for hiding this comment

cloudbehl commented May 8, 2020

bipuladh commented May 8, 2020

cloudbehl commented May 8, 2020

cloudbehl commented May 11, 2020

cloudbehl left a comment

Choose a reason for hiding this comment

cloudbehl May 12, 2020

Choose a reason for hiding this comment

bipuladh May 12, 2020

Choose a reason for hiding this comment

a2batic commented May 12, 2020

bipuladh commented May 12, 2020

bipuladh commented May 12, 2020

openshift-ci-robot commented May 12, 2020

bipuladh commented May 14, 2020

cloudbehl commented May 14, 2020

openshift-ci-robot commented May 14, 2020

openshift-ci-robot commented May 14, 2020

bipuladh commented Apr 30, 2020 •

edited

gnehapk commented May 7, 2020 •

edited