Bug 1828964: Adjust kubevirt modals footer buttons #5243
Conversation
openshift-ci-robot
added
component/kubevirt
|
@matthewcarleton please review |
yaacov
changed the title
yaacov
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@yaacov: This pull request references Bugzilla bug 1828964, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@yaacov: This pull request references Bugzilla bug 1828964, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@yaacov so for the cd-rom, boot order modals it looks like they are aligned to the middle of the viewport still. Is this a difficult thing to fix? |
|
@matthewcarleton hi,
only boot-order is in the middle of the screen [1].
Yes, boot-order modal is based on PF4 , I did not find prop or css that can easily move the modal to top [1] screenshot of whole screen with modal: |
|
/test e2e-gcp-console |
| <ActionGroup className="pf-c-form pf-c-form__actions--right pf-c-form__group--no-top-margin"> | ||
| <Button | ||
| type="button" | ||
| variant="secondary" |
There was a problem hiding this comment.
please use the typed version of variant
| > | ||
| {cancelButtonText} | ||
| </Button> | ||
| <Button variant="primary" isDisabled={isDisabled} id="confirm-action" onClick={onSubmit}> |
ah ya it's the bullseye layout that's being used so it would require some custom CSS to adjust it. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suomiy, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@yaacov: All pull requests linked via external trackers have merged: openshift/console#5243. Bugzilla bug 1828964 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The CNV details view modals do not align with what OCP has. We should adjust them to align them visually. CNV has set out to align better with Patternfly 4 but we should in the short term ensure we have a similar experience to the rest of the console.
This BZ align kubevirt plugin modal:
Note: In the case of boot-order modal we also need to top align the modal, this is not easily done for PF4 modal, IMHO we can wait until reset of the console will migrate to PF4, or find a fix that is PF4 ready, before fixing that.
Screenshots:
Before
After: