Bug 1830929: Feat(pl-filter-status): Add others as a filter status

[abhinandan13jan]

Fixes:

https://issues.redhat.com/browse/ODC-2401

Analysis / Root cause:

Other status to be set as a Pipeline List filter

Solution Description:

Added a new filter status Other to filters of Pipeline List

Screenshot

Browser conformation

Chrome 73

[andrewballantyne]

@abhinandan13jan Could you also handle Pipeline Runs? It has a similar look and feel and should be upgraded at the same time. I believe it's the same content as the Pipeline Details => Pipeline Runs tab as well, but please apply there as well if not.

[abhinandan13jan]

@abhinandan13jan Could you also handle Pipeline Runs? It has a similar look and feel and should be upgraded at the same time. I believe it's the same content as the Pipeline Details => Pipeline Runs tab as well, but please apply there as well if not.

Others include only the Pipelines, which have no runs associated with it... i.e no status. Should we cascade the others status as a default/safety block only? As Pipeline runs will have a status of their own and will not fall in the 'others' category.. @andrewballantyne

[abhinandan13jan]

/retitle Bug 1830929: Feat(pl-filter-status): Add others as a filter status
/retest

[openshift-ci-robot]

@abhinandan13jan: This pull request references Bugzilla bug 1830929, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1830929: Feat(pl-filter-status): Add others as a filter status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abhinandan13jan]

/test analyze

[andrewballantyne]

Fair @abhinandan13jan - my mistake. I was thinking of the "catch all" net that Others offered... but that is a fair point, we are not really going to get any use out of it right now so there is no need to add it.

[andrewballantyne]

/lgtm

[andrewballantyne]

@openshift/team-devconsole-ux FYI

I don't think we need to hold up the PR as they did approve the solution on the ticket. But still worth tagging them on PRs @abhinandan13jan

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@abhinandan13jan: All pull requests linked via external trackers have merged: openshift/console#5245. Bugzilla bug 1830929 has been moved to the MODIFIED state.

In response to this:

Bug 1830929: Feat(pl-filter-status): Add others as a filter status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.