Bug 1829928: Fixes: missing pod donut for DS in sidebar overview tab #5247
Conversation
openshift-ci-robot
added
the
bugzilla/severity-unspecified
|
@sahil143: This pull request references Bugzilla bug 1829928, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
component/shared
add PodRing to daemon set overview page refactor PodRingController utilities
openshift-ci-robot
removed
the
needs-rebase
| namespace, | ||
| prop: 'pods', | ||
| prop: podRingFirehoseProps[PodModel.kind], |
There was a problem hiding this comment.
do we need podRingFirehoseProps can we use PodModel.plural directly
There was a problem hiding this comment.
We have been using camelCase fro props name and these are being used in other places as well changing here will have to change in other places as well
| @@ -992,3 +992,20 @@ export const getPodsForStatefulSets = (ss: K8sResourceKind[], resources: any): P | |||
| }; | |||
| }); | |||
| }; | |||
|
|
|||
| export const getPodsForDaemonSets = (ds: K8sResourceKind[], resources: any): PodRCData[] => { | |||
There was a problem hiding this comment.
do we know type for resources
There was a problem hiding this comment.
For resources, we have been using any everywhere
|
/lgtm Verified locally seems both scenario for SS/DS works as expected |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, invincibleJai, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@sahil143: All pull requests linked via external trackers have merged: openshift/console#5247. Bugzilla bug 1829928 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: https://issues.redhat.com/browse/ODC-3114
Analysis / Root cause:
Missing PodRing for Daemon set overview page and sidebar
Missing EditPodCount action for StatefulSets menu action on sidebar
Solution Description:
Added PodRing for Daemon and EditPodCount action for StatefulSets menu action
Screen shots / Gifs for design review:
Unit test coverage report:
Test setup:
Browser conformance: