New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1829722: Fix various search input focus bugs #5252
Bug 1829722: Fix various search input focus bugs #5252
Conversation
* Don't autofocus the OperatorHub search input if a modal was opened while the page was loading. * Don't steal focus if a `/` character is typed in another text input. * Hide the focus keyboard hint when the search input is focused.
@spadgett: This pull request references Bugzilla bug 1829722, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@spadgett this seems fine for now. I have always checked |
@spadgett: All pull requests linked via external trackers have merged: openshift/console#5252. Bugzilla bug 1829722 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/
character is typed in another text input.https://bugzilla.redhat.com/show_bug.cgi?id=1829722
https://issues.redhat.com/browse/ODC-3554
@christianvogt This is a little hacky. I was looking for a non-invasive way to address the regression in 4.5. I'm on board doing something better long term. Let me know what you think.