Bug 1830096: Fix helm side panel in topology #5255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/ODC-3729
Analysis / Root cause: The topology side panel for helm was using
resource.kind
to get the model frommodelFor
. Some of the resources likeSecurityContextConstraints
need use group and api versions to create kind. Then onlymodelFor
would return correct model. This was not happening and the code was trying to domodel.kind
wheremodel
wasundefined
. So the UI was breaking with white screen.Solution Description: Use
referenceFor(resource)
to get fully functionalkind
strings of the resource which would then return correct model when used withmodelFor
. Also usingreferenceFor
when creating resource link.Screen shots / Gifs for design review:
Browser conformance: