Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1783109: Use buttons for perspective switcher dropdown items #5261

Merged
merged 1 commit into from May 1, 2020
Merged

Bug 1783109: Use buttons for perspective switcher dropdown items #5261

merged 1 commit into from May 1, 2020

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented May 1, 2020 •
edited

This is better for accessibility and prevents an "Open in New Window" context menu item, which won't work.

There is no change to the dropdown item appearance.

/assign @rhamilto

@spadgett
Bug 1783109: Use buttons for perspective switcher dropdown items
4ccabfa 
This is better for accessibility and prevents an "Open in New Window"
context menu item, which won't work.
@spadgett spadgett added this to the v4.5 milestone May 1, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label May 1, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1783109, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1783109: Use buttons for perspective switcher dropdown items

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality labels May 1, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1783109, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1783109: Use buttons for perspective switcher dropdown items

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto
rhamilto approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 432d1f0 into openshift:master May 1, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: All pull requests linked via external trackers have merged: openshift/console#5261. Bugzilla bug 1783109 has been moved to the MODIFIED state.

In response to this:

Bug 1783109: Use buttons for perspective switcher dropdown items

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the perspective-switcher-button branch May 4, 2020 14:04
@openshift-merge-robot
Copy link
Contributor

This PR was merged in the time period when ci-operator was mistakenly reporting failed tests as passing.

If this repository has ci-operator jobs, please inspect their test results even if passing, and consider the need for fixing or even reverting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spadgett @openshift-ci-robot @openshift-merge-robot @rhamilto