New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1830846: updates apiGroup for KnativeEventing to latest supported #5271
Bug 1830846: updates apiGroup for KnativeEventing to latest supported #5271
Conversation
@invincibleJai: This pull request references Bugzilla bug 1830846, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@invincibleJai: All pull requests linked via external trackers have merged: openshift/console#5271. Bugzilla bug 1830846 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@invincibleJai: #5271 failed to apply on top of branch "release-4.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3728
Analysis / Root cause:
With serverless GA eventing is part of it and user need not install knative Eventing operator[0]
with this there is change in group for KnativeEventing it has been moved to operator.knative.dev but in eventing operator it's still eventing.knative.dev (this will be deprecated) in devConsole we are leveraging KnativeEventing for feature flagging so Eventing maynot be shown if eventing is installed as part of serverless 1.7 GA. So going forward we need to be supporting operator.knative.dev
[0] https://access.redhat.com/documentation/en-us/openshift_container_platform/4.3/html-single/serverless_applications/index#serverless-getting-started
Solution Description:
updates apiGroup for KnativeEventing to latest supported i.e
operator.knative.dev
Screen shots / Gifs for design review:
TBD
Browser conformance: