New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1830878: event source connector drop target should only be knative service #5272
Bug 1830878: event source connector drop target should only be knative service #5272
Conversation
@invincibleJai: This pull request references Bugzilla bug 1830878, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @jeff-phillips-18 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@invincibleJai: All pull requests linked via external trackers have merged: openshift/console#5272. Bugzilla bug 1830878 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3739
Analysis / Root cause:
EventSource connector was droppable on workload of kind deployment/deploymentConfig, however should only be dropped/sinked to knative service
Solution Description:
Updated the drop condition to check type of node as well i.e restricting sink to only be in knative service
Screen shots / Gifs for design review:
Browser conformance: