Bug 1831071: Remove View Image Vulnerabilities action #5281
Conversation
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@spadgett: This pull request references Bugzilla bug 1831071, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
@spadgett: This pull request references Bugzilla bug 1831071, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
There is a `Vulnerabilities` tab on the pod page now, so the action is not needed. This is consistent with removing other actions like `View Environment` that just link to a tab.
spadgett
force-pushed
the
image-vuln-action
branch
from
4310029
to
670a9a0
Compare
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Of note is that this "Vulnerabilities" tab is showing the list of affected containers (which I forgot in my bugzilla comment) whereas the action was taking you to the list of ImageManifestVulns filtered to the ones related to this pod. We'd need to determine if this is sufficient to show the user or if there is another way to show the ImageManifestVulns, or if the action should stay. cc @alecmerdler |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
The Vulnerabilities tab is more intuitive than the filtered list of |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alecmerdler, itsptk, rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@spadgett: All pull requests linked via external trackers have merged: openshift/console#5281. Bugzilla bug 1831071 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There is a
Vulnerabilitiestab on the pod page now, so the action is not needed. This is consistent with removing other actions likeView Environmentthat just link to a tab./assign @itsptk @rhamilto