Bug 1831131: Fix Cluster Dashboard test #5288
Conversation
Update Channel will no longer be set in CI. Don't fail the test if it's `Not available`. See openshift/release#8631
openshift-ci-robot
added
kind/test-flake
|
@spadgett: This pull request references Bugzilla bug 1831131, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/lgtm |
| const text = values.get(i).getText(); | ||
| expect(text.length).not.toBe(0); | ||
| expect(text).not.toBe('Not available'); | ||
| } | ||
| // `Update Channel` is expected to be `Not available` in CI. |
There was a problem hiding this comment.
nit: With this PR, the console suite no longer cares if the channel is set or not, right? So this comment could be "Allow for Update Channel to be Not available in CI", or some such to match the code and stay fresh even if for whatever reason channels start getting set again in CI.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, jcaianirh, rawagner, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@spadgett: All pull requests linked via external trackers have merged: openshift/console#5288. Bugzilla bug 1831131 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update Channel will no longer be set in CI. Don't fail the test if it's
Not available.See openshift/release#8631
/kind test-flake