New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1831887: Address comments to PR 5336 #5289
Bug 1831887: Address comments to PR 5336 #5289
Conversation
import { K8sKind } from '@console/internal/module/k8s/types'; | ||
import { resourceTitle } from '@console/internal-integration-tests/views/crud.view'; | ||
import { click } from '@console/shared/src/test-utils/utils'; | ||
|
||
import { getResourceObject } from '../utils/utils'; | ||
import * as view from '../../views/uiResource.view'; | ||
|
||
const apiVersionForModel = (model: K8sKind) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suomiy I wasn't able to import this from @console/internal/model (circular dependency issue?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tried long import like this?
import { apiVersionForModel } from '@console/internal/module/k8s/k8s';
in case that doesn't work, can you move this to some utils file and write a short comment why it is duplicated
import { K8sKind } from '@console/internal/module/k8s/types'; | ||
import { resourceTitle } from '@console/internal-integration-tests/views/crud.view'; | ||
import { click } from '@console/shared/src/test-utils/utils'; | ||
|
||
import { getResourceObject } from '../utils/utils'; | ||
import * as view from '../../views/uiResource.view'; | ||
|
||
const apiVersionForModel = (model: K8sKind) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tried long import like this?
import { apiVersionForModel } from '@console/internal/module/k8s/k8s';
in case that doesn't work, can you move this to some utils file and write a short comment why it is duplicated
async openWizard(kind: K8sKind) { | ||
if (!(await resourceTitle.isPresent()) || (await resourceTitle.getText()) !== kind) { | ||
async openWizard(model: K8sKind) { | ||
if (!(await resourceTitle.isPresent()) || (await resourceTitle.getText()) !== model) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this always going to return true ? await resourceTitle.getText()) !== model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, thanks, I noticed that I also didn't update the resourceTitle (the Virtualization title has different attributes than on other pages)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
44fa89f
to
9830070
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhrazdil, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rhrazdil: This pull request references Bugzilla bug 1831887, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rhrazdil: All pull requests linked via external trackers have merged: openshift/console#5289. Bugzilla bug 1831887 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @suomiy @pcbailey