New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1827259: kubevirt: fix VM statuses #5297
Conversation
atiratree
commented
May 5, 2020
- fix stopping statuses
- give priority to error statuses over running
- make variable usage more clear
@suomiy: This pull request references Bugzilla bug 1827259, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
const migration = findVMIMigration(vm, migrations); | ||
const isBeingMigrated = ( | ||
vm: VMKind, | ||
vmiKind: VMIKind, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we call it vmi instead of vmiKind ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Succeeded = 'Succeeded', | ||
Failed = 'Failed', | ||
Unknown = 'Unknown', | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice !
- fix stopping statuses - give priority to error statuses over running - make variable usage more clear
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suomiy, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@suomiy: All pull requests linked via external trackers have merged: openshift/console#5297. Bugzilla bug 1827259 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |