Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1718489: Use a natural sort for list views #5322

Merged
merged 1 commit into from May 7, 2020
Merged

Bug 1718489: Use a natural sort for list views #5322

merged 1 commit into from May 7, 2020

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented May 6, 2020

Sort strings using a natural sort order in console list views.

https://en.wikipedia.org/wiki/Natural_sort_order

Screen Shot 2020-05-06 at 3 46 50 PM

/assign @rhamilto

@spadgett spadgett added this to the v4.5 milestone May 6, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 6, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1718489, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.3.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1718489: Use a natural sort for list views

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett
spadgett commented May 6, 2020
View reviewed changes
frontend/public/components/factory/table.tsx
const currentSortOrder = UI.getIn(['listSorts', listId, 'orderBy'], defaultSortOrder);

if (loaded) {
let sortBy: string | Function = 'metadata.name';
if (currentSortField) {
if (currentSortAsNumber) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sortAsNumber is no longer needed with { numeric: true }

@spadgett
Bug 1718489: Use a natural sort for list views
3bbb554 
Sort strings using a natural sort order in console list views.

https://en.wikipedia.org/wiki/Natural_sort_order
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label May 6, 2020
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 6, 2020
@spadgett
Copy link
Member Author

spadgett commented May 6, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 6, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1718489, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto
rhamilto reviewed May 6, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rhamilto
Copy link
Member

rhamilto commented May 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a0fa6a6 into openshift:master May 7, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: All pull requests linked via external trackers have merged: openshift/console#5322. Bugzilla bug 1718489 has been moved to the MODIFIED state.

In response to this:

Bug 1718489: Use a natural sort for list views

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the natural-sort branch May 7, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spadgett @openshift-ci-robot @rhamilto @openshift-merge-robot